refactor: improve conditional compilation in get_pipe_open_options #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-matthias
approved these changes
Jul 18, 2025
- Replace multiple early returns with a single mutable variable approach - Add conditional allow(unused_mut) attribute for non-Linux platforms - Makes the code more concise while maintaining the same functionality
art049
force-pushed
the
refactor/improve-pipe-options-conditional-compilation
branch
from
56ca598 to
c7e68dd
Compare
art049
deleted the
refactor/improve-pipe-options-conditional-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
get_pipe_open_options()function to use a single mutable variable approach instead of multiple early returns#[cfg_attr(not(target_os = "linux"), allow(unused_mut))]attribute to suppress unused mut warnings on non-Linux platformsBenefits
Testing