Skip to content

Conversation

not-matthias
Copy link
Member

No description provided.

@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch 2 times, most recently from 77579dd to ea5cba7 Compare August 5, 2025 13:30
@not-matthias not-matthias marked this pull request as ready for review August 5, 2025 13:31
@not-matthias not-matthias requested review from Copilot and art049 August 5, 2025 13:31
Copilot

This comment was marked as outdated.

@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch from ea5cba7 to d8efbe3 Compare August 5, 2025 13:36
@not-matthias not-matthias requested a review from Copilot August 5, 2025 13:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds instrumentation for Go shell scripts by introducing a custom go wrapper script that intercepts go test commands and routes them through a specialized go-runner tool while preserving normal behavior for other Go commands.

  • Adds a new introspected_golang module with setup functionality for the Go wrapper script
  • Introduces a shell script that intercepts Go commands and routes test commands to go-runner
  • Integrates the Go instrumentation into the wall time executor by modifying PATH environment

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/run/runner/wall_time/mod.rs Exports the new introspected_golang module
src/run/runner/wall_time/introspected_golang/mod.rs Implements setup function to create and configure the Go wrapper script
src/run/runner/wall_time/introspected_golang/go.sh Shell script that intercepts Go commands and routes test commands to go-runner
src/run/runner/wall_time/executor.rs Integrates Go instrumentation by adding the script directory to PATH

@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch from d8efbe3 to d3b14ff Compare August 5, 2025 13:39
@not-matthias not-matthias removed the request for review from art049 August 26, 2025 07:49
@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch from d3b14ff to 866d021 Compare August 26, 2025 15:04
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch from 866d021 to 0e61ce5 Compare August 28, 2025 09:37
@not-matthias not-matthias force-pushed the cod-1208-run-golang-with-walltime-in-runner branch from 0e61ce5 to 0d43ca2 Compare August 28, 2025 10:27
@not-matthias not-matthias merged commit 0d43ca2 into main Aug 28, 2025
9 checks passed
@not-matthias not-matthias deleted the cod-1208-run-golang-with-walltime-in-runner branch August 28, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants