Skip to content

Conversation

not-matthias
Copy link
Member

@not-matthias not-matthias commented Aug 28, 2025

We had a similar issue before and attempted to fix it in #99. The logic was a bit off, I've now corrected it and added some tests to ensure it will continue to work in the future.

@not-matthias not-matthias requested a review from art049 August 28, 2025 18:01
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lmk when you have additional tests for Python + Rust, as we discussed

@not-matthias not-matthias force-pushed the cod-1279-invalid-symbol-address-for-golang-binary branch 3 times, most recently from 792b788 to a6a1a12 Compare September 1, 2025 10:21
@not-matthias
Copy link
Member Author

Nice, lmk when you have additional tests for Python + Rust, as we discussed

Verified the changes for Cpp, Rust and Golang. I've added test cases for a failing example and made sure the flamegraphs are the same.

The python runner implementation isn't fully completely (see #103 ) + my uv env is completely broken so I skipped it for now. But I'm very confident that it will work for Python as well.

@not-matthias not-matthias requested a review from art049 September 1, 2025 11:45
@not-matthias not-matthias force-pushed the cod-1279-invalid-symbol-address-for-golang-binary branch from a6a1a12 to a136236 Compare September 1, 2025 13:18
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great let's ship this then!

@not-matthias not-matthias merged commit a136236 into main Sep 1, 2025
9 checks passed
@not-matthias not-matthias deleted the cod-1279-invalid-symbol-address-for-golang-binary branch September 1, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants