-
Notifications
You must be signed in to change notification settings - Fork 40
Dark Mode Bug Fix for Blog and Projects Pages #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -86,7 +86,7 @@ export const Blog: React.FC = () => { | |||||
|
|
||||||
| if (loading) { | ||||||
| return ( | ||||||
| <div className="min-h-screen bg-gray-50 py-12 flex items-center justify-center"> | ||||||
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-12 flex items-center justify-center"> | ||||||
| <div className="text-center"> | ||||||
| <div className="animate-spin rounded-full h-12 w-12 border-b-2 border-purple-600 mx-auto mb-4"></div> | ||||||
| <p className="text-gray-600">Loading blog posts...</p> | ||||||
|
|
@@ -98,11 +98,11 @@ export const Blog: React.FC = () => { | |||||
| if (error) { | ||||||
| return ( | ||||||
| <div className="min-h-screen bg-gray-50 py-12 flex items-center justify-center"> | ||||||
|
||||||
| <div className="min-h-screen bg-gray-50 py-12 flex items-center justify-center"> | |
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-12 flex items-center justify-center"> |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] For consistency with other components in the codebase (Community, Challenges, Profile, etc.), consider adding transition-colors duration-300 to the main container div to provide smooth transitions when toggling dark mode.
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-8"> | |
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-8 transition-colors duration-300"> |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] For consistency with other components in the codebase (Community, Challenges, Profile, etc.), consider adding transition-colors duration-300 to the main container div to provide smooth transitions when toggling dark mode.
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-12"> | |
| <div className="min-h-screen bg-gray-50 dark:bg-gray-900 py-12 transition-colors duration-300"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loading text should have a dark mode variant to ensure readability on dark backgrounds. Add
dark:text-gray-300to match the pattern used elsewhere in the component.