Skip to content

Fix snapshot pagination bug #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix snapshot pagination bug #363

wants to merge 2 commits into from

Conversation

majecty
Copy link
Contributor

@majecty majecty commented Apr 22, 2020

  • I checked the result of the query by creating a small JavaScript program. Its result was { count: '2' }.
  • I found that there were no point that deserializing the query parameter. I checked it by printing the lastEvaluatedKey after JSON.parse. It can handle a query like `curl -vG 'localhost:9001/api/snapshot?assetType=30a62cfe15b1993b26f95d86234da236ec4e02c2&date=2020-04-20' --data-urlencode 'lastEvaluatedKey=[0,0]'

@majecty majecty requested a review from joojis April 22, 2020 03:37
@joojis joojis removed their request for review May 11, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@majecty