-
Notifications
You must be signed in to change notification settings - Fork 31
feat(CodeConnect): Atoms #3159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(CodeConnect): Atoms #3159
Conversation
* new rulez * menu + disclosure
View your CI Pipeline Execution ↗ for commit da261a9 ☁️ Nx Cloud last updated this comment at |
@@ -0,0 +1,45 @@ | |||
import { client } from '@figma/code-connect'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we actually need this entire file, it was a WIP from hackathon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments but looks awesome, can't wait to start using it!
npx figma connect publish --token=PERSONAL_ACCESS_TOKEN | ||
``` | ||
|
||
There are future plans to eliminate the need for individuals to publish these files and use GitHub Actions instead. Stay tuned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should keep this internal to Gamut for now? i don't really want other teams publishing to CodeConnect just yet
export const parameters = { | ||
id: 'Meta/MCP', | ||
title: 'MCP', | ||
subtitle: 'Documentation related to the Figma Model Context Protocol.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Myabe add soemthing like "exclusive to Codecademy + Skillsoft employees" or something like that
}), | ||
// placeholder: figma.nestedProps('placeholder', { | ||
// true: 'Placeholder text', | ||
// false: undefined, | ||
// }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out code
// No matching props could be found for these Figma properties: | ||
// "size": figma.enum('size', { | ||
// "Large": "large", | ||
// "Medium": "medium", | ||
// "Small": "small", | ||
// "XL": "xl" | ||
// }), | ||
// "variant": figma.enum('variant', { | ||
// "default": "default", | ||
// "yellow": "yellow", | ||
// "blue": "blue" | ||
// }), | ||
// "percent": figma.enum('percent', { | ||
// "0%": "0-", | ||
// "25%": "25-", | ||
// "50%": "50-", | ||
// "75%": "75-", | ||
// "100%": "100-" | ||
// }), | ||
// "pattern": figma.boolean('pattern'), | ||
// "flat": figma.enum('flat', { | ||
// "n/a": "n-a", | ||
// "flat-top": "flat-top", | ||
// "flat-bottom": "flat-bottom" | ||
// }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can prob delete
// defaultValue: figma.enum('type', { | ||
// text: 'Input text', | ||
// number: '0', | ||
// file: undefined, | ||
// }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good catch, Stacey made an update, but I didn't update the code connect file, will do that now! thanks~
📬Published Alpha Packages:@codecademy/[email protected] |
🚀 Styleguide deploy preview ready! |
Overview
code-connect
folder in/packages
code-connect
PR Checklist
Testing Instructions
Don't make me tap the sign.
/?path=/docs/meta-about--docs
—-
Would love feedback on:
PR Links and Envs
N/A any changes are reflected in Storybook.
The
code-connect
directory isn't part of thegamut-kit
package.