feat: add abbreviations to SelectDropdown, fixed grouped select + formatting issues #3167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 3b333d5
☁️ Nx Cloud last updated this comment at |
dreamwasp
changed the title
aresnik11
reviewed
Sep 11, 2025
aresnik11
reviewed
Sep 11, 2025
aresnik11
reviewed
Sep 11, 2025
packages/gamut/src/Form/__tests__/SelectDropdownGrouped.test.tsx
Outdated
Show resolved
Hide resolved
aresnik11
reviewed
Sep 11, 2025
packages/styleguide/src/lib/Atoms/FormInputs/SelectDropdown/SelectDropdown.stories.tsx
Show resolved
Hide resolved
LinKCoding
reviewed
Sep 11, 2025
There was a problem hiding this comment.
Noticed that the Icon example in SB strips away the icon in the Input after selecting an option.
Left some thoughts and a question that I'm curious about — if you'd rather these can be fast follows instead (or declined suggestions lol)
Nice work on fixing SelectDropdown!!
| // We only update this when our passed in options or value changes, not multiValues. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [value]); | ||
| }, [options, value]); |
There was a problem hiding this comment.
this works great 🙇 !
|
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:@codecademy/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds abbreviation to SelectDropdown and misc fixes such as static height + text truncation, fixed grouped select option selection, multi-select tag formatting issues, and added overall better docs, organization, and tests
PR Checklist
Testing Instructions
PR Links and Envs