Skip to content

ci: swap test suite to GHA #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

ci: swap test suite to GHA #3185

wants to merge 27 commits into from

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 9, 2025 •
edited
Loading

Overview

Migrates test suite from CircleCI to GitHub Actions, fixes act warnings, and excludes auto-generated icon/pattern files from Jest coverage reports to reduce noise.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [gmt-1442]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Verify GHA workflow runs - Check Actions tab shows "Test Suite" passing and you don't see errors or warnings
  2. Check out the failing test here - this should fail #3186
  3. Run npx nx test gamut-icons --coverage - should only show 4 source files, NO generated icons
  4. Run npx nx test gamut-patterns --coverage - should only show 4 source files, NO generated patterns
  5. Run npx nx affected --target=test --parallel=4 --ci --coverage - should be much cleaner, no dist/icons/ or dist/patterns/ noise
  6. Celebrate! 🎉

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f58019e

Command Status Duration Result
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-14 16:50:01 UTC

Base automatically changed from cass-GMT-285 to main October 14, 2025 14:45
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@github-actions GitHub Actions
Copy link
Contributor

🚀 Styleguide deploy preview ready!

Preview URL: https://68ee7ff0a4e6989bc06ef044--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/68ee7ff0a4e6989bc06ef044

@dreamwasp dreamwasp changed the title start changing test ci: swap test suite to GHA Oct 16, 2025
@dreamwasp dreamwasp marked this pull request as ready for review October 16, 2025 18:32
@dreamwasp dreamwasp requested a review from a team as a code owner October 16, 2025 18:32
jakemhiller
jakemhiller reviewed Oct 16, 2025
View reviewed changes
jakemhiller
jakemhiller approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the other PR the tests aren't running against this PR yet, but it looks good in the test branch, and the code looks good to me 👍

@dreamwasp @jakemhiller
Update jest.config.base.ts
64a4b0a 
Co-authored-by: Jake Hiller <[email protected]>
@dreamwasp
Copy link
Contributor Author

similar to the other PR the tests aren't running against this PR yet, but it looks good in the test branch, and the code looks good to me 👍

😮‍💨 oopsy, will fix again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dreamwasp @codecademydev @jakemhiller