Skip to content

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 24, 2025

Overview

maxWidth of horizontal Tooltips is now 64px. i also cleaned up some other width inconsistencies i noticed

PR Checklist

  • Related to JIRA ticket: GMT-115
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to the Tooltip story
  2. Type something short into the ToolTip story and see that with narrow toggled on the tip is the width of the content
  3. Do the same for the floating variant
  4. Type something long and see the maxWidth is 64px

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2025

View your CI Pipeline Execution ↗ for commit d7016db


☁️ Nx Cloud last updated this comment at 2025-11-03 14:24:18 UTC

@dreamwasp dreamwasp changed the title feat(Tip): L/R center narrow minWidth feat(Tip): L/R center narrow maxWidth Oct 28, 2025
@dreamwasp dreamwasp marked this pull request as ready for review October 29, 2025 16:54
@dreamwasp dreamwasp requested a review from a team as a code owner October 29, 2025 16:54
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this expected? inline vs floating
Screenshot 2025-10-31 at 1 18 27 PM
Screenshot 2025-10-31 at 1 18 32 PM

@dreamwasp
Copy link
Contributor Author

is this expected? inline vs floating Screenshot 2025-10-31 at 1 18 27 PM Screenshot 2025-10-31 at 1 18 32 PM

is this

is this expected? inline vs floating Screenshot 2025-10-31 at 1 18 27 PM Screenshot 2025-10-31 at 1 18 32 PM

this is the non-narrow version? must be the same beak issue i was seeing with narrow, will fix

@dreamwasp dreamwasp requested a review from aresnik11 October 31, 2025 19:23
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Nov 3, 2025
@codecademydev codecademydev merged commit e9b8543 into main Nov 3, 2025
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 3, 2025
@codecademydev codecademydev deleted the cass-gmt-115 branch November 3, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants