Skip to content

Commit

Permalink
Test against PHP 8.4 (#13)
Browse files Browse the repository at this point in the history
* Test against PHP 8.4
* Bump actions/checkout dependency
* Drop support for PHP 8.0
* Remove superfluous check
  • Loading branch information
W0rma authored Nov 11, 2024
1 parent bc7c96a commit f35b4a2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ jobs:

strategy:
matrix:
php: [8.0, 8.1, 8.2, 8.3]
php: [8.1, 8.2, 8.3, 8.4]

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
],
"homepage": "https://codeception.com/",
"require": {
"php": "^8.0",
"php": "^8.1",
"ext-mbstring": "*",
"guzzlehttp/psr7": "^2.0",
"phpunit/phpunit": "^9.5 | ^10.0 | ^11.0",
Expand Down
10 changes: 4 additions & 6 deletions src/Util/Locator.php
Original file line number Diff line number Diff line change
Expand Up @@ -338,11 +338,9 @@ public static function humanReadableString(WebDriverBy|array|string $selector):
$locator = $selector[$type];
return "{$type} '{$locator}'";
}
if (class_exists('\Facebook\WebDriver\WebDriverBy') && $selector instanceof WebDriverBy) {
$type = $selector->getMechanism();
$locator = $selector->getValue();
return "{$type} '{$locator}'";
}
throw new InvalidArgumentException("Unrecognized selector");

$type = $selector->getMechanism();
$locator = $selector->getValue();
return "{$type} '{$locator}'";
}
}

0 comments on commit f35b4a2

Please sign in to comment.