Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare nullable parameter types explicitly for PHP 8.4 compatibility #12

Merged

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Jul 26, 2024

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types deprecates implicitly nullable parameter types in PHP 8.4

@TavoNiievez
Copy link
Member

Hi @W0rma,

It seems that it is now possible to test with github actions PHP 8.4, see 8.4-rc, I am approving these PRs considering the change you apply and the reason why you do it, but in the future it would be appropriate to test that PHP 8.4 compatibility is something that is actually working.

Then, we should instead adapt the actions to verify that we have no deprecations, because technically we are already compatible with PHP 8.4, this change is strictly required for PHP 9.0.

Finally, feel free to tag me in the PRs you consider urgent, as long as I have ever used the repository I will be able to help you by reviewing them. Currently I only have notifications enabled for codeception, module-symfony and symfony-module-tests.

@W0rma W0rma force-pushed the explicit-nullable-parameter-type branch 2 times, most recently from 0bac627 to 78806d3 Compare July 31, 2024 08:51
@W0rma
Copy link
Contributor Author

W0rma commented Jul 31, 2024

@TavoNiievez Sorry, I should have used a better title for my MRs.

In fact they only fix a deprecation warning in PHP 8.4.

Seems like phpstan is not yet compatible with PHP 8.4 (see phpstan/phpstan#10182), therefore the PHP 8.4 would currently fail.

@TavoNiievez TavoNiievez merged commit bc7c96a into Codeception:main Jul 31, 2024
8 checks passed
@W0rma W0rma deleted the explicit-nullable-parameter-type branch August 1, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants