chore: remove deprecated and unimplemented code #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2025 10:34
- Delete compat.rs module (547 lines of unused migration code) - Delete root plugins.json and crates/app/plugins.json (use config/plugins.json) - Delete STT plugin stubs: coqui.rs, leopard.rs, silero_stt.rs, whisper_cpp.rs - Delete legacy processor.rs from coldvox-stt - Delete orphaned test_enigo_live.rs and PR-190-Comprehensive-Assessment.md - Delete docs/history/ chat transcripts - Delete .tests_temp/ orphaned test directory - Remove deprecated Context type aliases from injector modules - Remove placeholder feature flags from coldvox-stt/Cargo.toml - Fix atspi API migration (ObjectRefOwned fields ??? methods) Keeps working implementations: mock, noop, parakeet plugins
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive cleanup of deprecated and unimplemented code across the ColdVox workspace to reduce maintenance burden and clarify implementation boundaries.
Key Changes
- Removed unused migration compatibility code: Deleted
compat.rs(547 lines) which provided legacy JSON configuration migration that was never actually used in the codebase - Deleted stub STT plugin implementations: Removed placeholder files for
coqui,leopard,silero_stt, andwhisper_cppplugins that return "not yet implemented" errors - Removed legacy STT processor: Deleted
processor.rsmarked as "legacy (EventBasedTranscriber-based) processor" - Fixed atspi API migration: Updated references from field access (
.name,.path) to method calls (.name(),.path()) to match the current atspi library API - Removed deprecated Context type aliases: Cleaned up backward compatibility type aliases that redirected to
InjectionContext - Consolidated plugin configuration: Removed duplicate
plugins.jsonfiles at repository and app root, keeping only the canonicalconfig/plugins.json - Cleaned up orphaned test files: Removed
.tests_temp/directory and standalone test file at repository root
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/coldvox-text-injection/src/compat.rs |
Deleted unused 547-line migration compatibility module |
crates/coldvox-text-injection/src/lib.rs |
Removed compat module export and deprecated ClipboardContext re-export |
crates/coldvox-text-injection/src/injectors/mod.rs |
Removed deprecated Context type alias re-exports for AtspiContext and ClipboardContext |
crates/coldvox-text-injection/src/injectors/clipboard.rs |
Removed deprecated Context type alias and updated atspi API calls to use methods |
crates/coldvox-text-injection/src/injectors/atspi.rs |
Removed deprecated Context type alias and migrated atspi field access to method calls |
crates/coldvox-text-injection/src/prewarm.rs |
Updated atspi API calls: obj_ref.name() and obj_ref.path() instead of field access |
crates/coldvox-text-injection/src/manager.rs |
Updated atspi API calls to use obj_ref.name() and obj_ref.path() methods |
crates/coldvox-text-injection/src/confirm.rs |
Updated atspi API calls to method-based access pattern |
crates/coldvox-text-injection/.tests_temp/* |
Deleted entire orphaned test directory with 14 test files |
crates/coldvox-stt/src/processor.rs |
Removed legacy 234-line STT processor marked as deprecated |
crates/coldvox-stt/src/lib.rs |
Removed processor module export |
crates/coldvox-stt/src/plugins/coqui.rs |
Deleted 223-line stub for Coqui STT plugin |
crates/coldvox-stt/src/plugins/leopard.rs |
Deleted 233-line stub for Picovoice Leopard plugin |
crates/coldvox-stt/src/plugins/silero_stt.rs |
Deleted 303-line stub for Silero STT plugin |
crates/coldvox-stt/src/plugins/whisper_cpp.rs |
Deleted 374-line stub for Whisper.cpp plugin |
crates/coldvox-stt/src/plugins/mod.rs |
Removed stub plugin module declarations and re-exports |
crates/coldvox-stt/Cargo.toml |
Removed placeholder feature flags (whisper, coqui, leopard, silero-stt) |
plugins.json |
Deleted duplicate configuration file at repository root |
crates/app/plugins.json |
Deleted duplicate configuration file in app crate |
crates/app/config/plugins.json |
Fixed BOM character at file start |
test_enigo_live.rs |
Deleted standalone test file at repository root |
docs/history/*.md |
Deleted 3 chat transcript markdown files from development history |
PR-190-Comprehensive-Assessment.md |
Deleted stale PR assessment document |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated, orphaned, and unimplemented code across the workspace to reduce maintenance surface and clarify the current implementation boundaries.
Summary of changes:
crates/coldvox-text-injection/src/compat.rs(unused migration compat).crates/coldvox-stt/src/processor.rs(legacy STT processor not referenced).coqui.rs,leopard.rs,silero_stt.rs,whisper_cpp.rs.crates/coldvox-stt/Cargo.toml.plugins.jsonandcrates/app/plugins.json(canonical isconfig/plugins.json)..tests_tempincrates/coldvox-text-injectionandtest_enigo_live.rsat repo root.Contexttype aliases and their exports, and updated references.obj_ref.name()).Status:
cargo check --workspaceandcargo test --workspacecomplete successfully locally.Follow-ups (recommended):
run_for_method()and remove the genericrun()once done..tests_temp/folder intosrc/tests/.Notes: The PR intentionally keeps working implementations like
mock,noop, andparakeetplugins. Stub plugin implementations should be replaced by concrete backends in separate PRs.PR created by bot on branch
chore/cleanup-deprecated-code.