Skip to content

feat(moonshine): upgrade PyO3 to 0.27 for Python 3.13 compatibility #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Coldaine wants to merge 5 commits into from
Closed

feat(moonshine): upgrade PyO3 to 0.27 for Python 3.13 compatibility #294

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaf36f4
chore: align repo, add moonshine verification and venv automation
Dec 11, 2025
9c2ae87
feat(moonshine): upgrade PyO3 to 0.27 for Python 3.13 compatibility
Dec 12, 2025
e0c7783
fix: address PR #294 review feedback
Dec 12, 2025
8f33d2a
fix: gate verify_moonshine example behind moonshine feature
Dec 12, 2025
c27f96b
fix: clear all CI env vars in test_detect_development_environment
Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .envrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Automatically activate Python venv and sync dependencies on cd
# Requires: direnv (https://direnv.net/)
# Install: sudo apt install direnv && echo 'eval "$(direnv hook bash)"' >> ~/.bashrc

# Create venv if it doesn't exist
if [[ ! -d .venv ]]; then
echo "Creating .venv with uv..."
uv venv .venv
fi

# Activate the venv
source .venv/bin/activate

# Ensure dependencies are synced
uv sync --quiet
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states "Ensure dependencies are synced" but uv sync --quiet could fail silently. Consider removing the --quiet flag or adding error handling to ensure failures are visible to the developer.

Suggested change
uv sync --quiet
uv sync

Copilot uses AI. Check for mistakes.

# Set PYO3 to use this venv's Python
Comment on lines +16 to +17
Copy link

@kiloconnect kiloconnect bot Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 SUGGESTION: Improve error visibility

The --quiet flag on uv sync could hide important errors during development. Consider removing it or adding explicit error handling:

# Ensure dependencies are synced
uv sync || {
    echo "Error: Failed to sync dependencies"
    exit 1
}

export PYO3_PYTHON="${PWD}/.venv/bin/python"
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ flamegraph.svg
.env.local
.venv/

# AI Agent Frameworks (BMAD, Claude, etc)
.bmad/
.claude/

# Logs
logs/
*.log
Expand Down Expand Up @@ -77,4 +81,3 @@ docs/config.md
docs/install.md
docs/reference.md
docs/usage.md
.venv/
Loading
Loading