Skip to content

docs: mark Phases 2-4 complete in PR triage action plan #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Coldaine wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: mark Phases 2-4 complete in PR triage action plan #313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions docs/plans/2025-12-23-pr-triage-action-plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ last_reviewed: 2025-12-23

**Date**: 2025-12-23
**Status**: Active
**Last Updated**: 2025-12-23 (session corrections applied)
**Last Updated**: 2025-12-23 (Phases 2-4 complete)
**Scope**: Analysis of 50 PRs (open, draft, and closed)

---
Expand Down Expand Up @@ -365,33 +365,33 @@ obj_ref.path → obj_ref.path_as_str()
- [ ] Close PR #262 with comment "Superseded by #282"
- [ ] Close stale Jules drafts: #277, #274, #255, #256, #258, #261

### Phase 2: Cleanup PR (This Week)
### Phase 2: Cleanup PR ✅ COMPLETE (2025-12-23)

- [ ] Fix PR #282 CI failures
- [ ] Documentation validation
- [ ] Build & test
- [ ] Text injection tests
- [ ] Merge PR #282
- [x] Fix PR #282 CI failures
- [x] Documentation validation (added YAML frontmatter to 3 docs)
- [x] Build & test
- [x] Text injection tests
- [x] Merge PR #282
- [ ] Optionally incorporate valuable #262 deletions:
- [ ] `compat.rs` removal
- [ ] `processor.rs` removal
- [ ] `.tests_temp/` cleanup

### Phase 3: Dependency Update (This Week)
### Phase 3: Dependency Update ✅ COMPLETE (2025-12-23)

- [ ] Create branch from #300
- [ ] Fix CPAL 0.17.0 breaking changes:
- [ ] Update `SampleRate` usage in `device.rs`
- [ ] Remove `.0` field access in `device.rs`, `capture.rs`
- [ ] Replace `device.name()` with `device.description()`
- [ ] Test audio device detection
- [ ] Merge updated PR #300
- [x] Create branch from #300
- [x] Fix CPAL 0.17.0 breaking changes:
- [x] Update `SampleRate` usage in `device.rs`
- [x] Remove `.0` field access in `device.rs`, `capture.rs`
- [x] Replace `device.name()` with `device.description()` (8 locations)
- [x] Test audio device detection
- [x] Merge updated PR #300

### Phase 4: Test Infrastructure (Next Week)
### Phase 4: Test Infrastructure ✅ COMPLETE (2025-12-23)

- [ ] Review and merge PR #276 (Xvfb CI)
- [ ] Review and merge PR #273 (ydotool tests)
- [ ] Review and merge PR #268 (enigo/kdotool tests)
- [x] Review and merge PR #276 (Xvfb CI) → PR #310 created
- [x] Review and merge PR #273 (ydotool tests) → PR #311 created
- [x] Review and merge PR #268 (enigo/kdotool tests) → PR #312 created
- [ ] Review PR #232 (AT-SPI focus) - test separately

### ~~Phase 5: PyO3 Upgrade~~ (COMPLETE)
Expand Down
Loading