chore(issues): clean up and correct any bad refs for issue endpoints,…

… add comments to document endpoints
ColumbiaJS · Mar 15, 2015 · ef4461f · ef4461f
1 parent e3d0219
commit ef4461f
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 11 deletions.
diff --git a/public/app/issue/Issue.js b/public/app/issue/Issue.js
@@ -26,8 +26,8 @@
         var endpoint = this.endpointWithId() + '/links/' + link._id;
         return $http.delete(endpoint).then(getDeleteData);
       },
-      deleteFounder: function(founder) {
-        var endpoint = this.endpointWithId() + '/founders/' + founder._id;
+      deleteIssue: function(issue) {
+        var endpoint = this.endpointWithId() + '/issues/' + issue._id;
         return $http.delete(endpoint).then(getDeleteData);
       },
       endpointWithId: function() {
@@ -42,8 +42,6 @@
       return dataToReturn;
     }
 
-
-
     return Issue;
   });
 }());
diff --git a/public/app/issue/issue-list.html b/public/app/issue/issue-list.html
@@ -1,5 +1,4 @@
-<div layout="column"
-     hotkey="{right: vm.reselect, space: vm.reselect}">
+<div layout="column">
 
  <section layout="row" flex>
   <md-toolbar md-scroll-shrink>

diff --git a/server/api/issues/index.js b/server/api/issues/index.js
@@ -1,6 +1,15 @@
 (function () {
   'use strict';
 
+  /*
+   * ENDPOINTS:
+   * GET     /api/issues     -> index
+   * POST    /api/issues     -> create
+   * GET     /api/issues/:id -> show
+   * PUT     /api/issues/:id -> update
+   * DELETE  /api/issues/:id -> destroy
+   */
+
   var express    = require('express'),
       router     = express.Router(),
       controller = require('./issues.controller');

diff --git a/server/api/issues/issue.model.js b/server/api/issues/issue.model.js
@@ -5,10 +5,11 @@
       qs       = require('querystring'),
       ObjectId = mongoose.Schema.Types.ObjectId,
       ts       = require('../../db/plugins/timestamps'),
-      _        = require('lodash');
+      _        = require('lodash'),
+      STATES   = ['open', 'close'];
 
   var Issue;
-  var STATES = ['open', 'close'];
+
   var IssueSchema = mongoose.Schema({
     url: String,
     labels: [],

diff --git a/server/config/routes.js b/server/config/routes.js
@@ -30,11 +30,8 @@
     app.use('/api/issues', require('../api/issues'));
     app.use('/auth', require('../auth'));
 
-
-
     app.route('/partials/*')
       .get(clientViews.viewPartials);
-    // i think the below is the express 4 way to do it
 
     // All undefined asset or api routes should return a 404
     app.route('/:url(api|auth|components|app|bower_components|assets)/*')