feat(Logger): Implement LogAPI #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base information
Objective
Currently this module logs in a separate file and doesn't use the same format as the regular
error.log. Which makes it harder/impossible to investigate using the Logs Center fromitop-log-mgmtincluded in iTop Products.Proposed solution
Refactor the existing
Loggerto implement theLogAPIby extendingIssueLog, which makes it use the same structure in the file and also use the sameerror.log. Channel is set toSAMLso these logs can easily be filtered out for investigation. Also the same behaviour regarding thedebugmodule setting is kept. Default log level is Warning, but set to Trace whendebugis set totrue.Checklist before requesting a review
Checklist of things to do before PR is ready to merge