Skip to content

Conversation

@Kosinkadink
Copy link
Member

At its core, this PR is a super small slice of this one: #10045

A fast scan of model files occurs upon startup and calling the /object_info endpoint. No hashing happens at this point in time.

Only 3 http endpoints are added:

  • GET /api/assets
  • GET /api/assets/{{id:{UUID_RE}}}
  • GET /api/tags

Adds an assets database with tag support that fully reflects the work done in the previous assets PR, enabling more functionality to be added as needed without modifying database schema.

Adds an unused hashing function that uses blake3, has support for resuming hashing from midway into a file, and can accept either an absolute path as input or an open file reference.

Note: since the hashing is not enabled, requirements.txt is not updated to add blake3 as a dependency in this PR.

Adding tests would make sense. The ones in the original PR are very verbose and I have not translated them yet to be in this PR.

@comfyanonymous comfyanonymous merged commit 1dc3da6 into master Jan 9, 2026
17 checks passed
@comfyanonymous comfyanonymous deleted the assets-redo branch January 9, 2026 03:21
@Leseratte10
Copy link

Leseratte10 commented Jan 10, 2026

Since this merge, ComfyUI fails to start for me with the error Can't use explicit RETURNING for bulk INSERT operation with sqlite+pysqlite backend; executemany with RETURNING is not enabled for this dialect.; see #11792 for more details. Any idea what that means?

@Kosinkadink
Copy link
Member Author

@Leseratte10 Now that's new - thank you for the report! I'd love to get more info about your ComfyUI install in order to track down a fix. If you're familiar with the terminal/ComfyUI, could you enter your ComfyUI's venv and run pip freeze, and reply with the full output of that? Lmk if you'd need more detailed instructions.

@Leseratte10
Copy link

Leseratte10 commented Jan 10, 2026

Thanks for the quick response, here's the output of "pip freeze":

Versions
aiofiles==24.1.0
aiohappyeyeballs==2.6.1
aiohttp==3.13.3
aiohttp_socks==0.11.0
aiosignal==1.4.0
alembic==1.17.2
annotated-types==0.7.0
attrs==25.4.0
av==16.0.1
certifi==2026.1.4
cffi==2.0.0
chardet==5.2.0
charset-normalizer==3.4.4
click==8.3.1
comfy-kitchen==0.2.5
comfyui-embedded-docs==0.3.1
comfyui-workflow-templates-core==0.3.77
comfyui-workflow-templates-media-api==0.3.34
comfyui-workflow-templates-media-image==0.3.50
comfyui-workflow-templates-media-other==0.3.68
comfyui-workflow-templates-media-video==0.3.33
comfyui_frontend_package==1.36.13
comfyui_workflow_templates==0.7.69
cryptography==46.0.3
einops==0.8.1
filelock==3.20.2
frozenlist==1.8.0
fsspec==2025.12.0
gguf==0.17.1
gitdb==4.0.12
GitPython==3.1.46
greenlet==3.3.0
h11==0.16.0
h2==4.3.0
hf-xet==1.2.0
hpack==4.1.0
huggingface-hub==0.36.0
hyperframe==6.1.0
idna==3.11
Jinja2==3.1.6
jsonschema==4.26.0
jsonschema-specifications==2025.9.1
kornia==0.8.2
kornia_rs==0.1.10
Mako==1.3.10
markdown-it-py==4.0.0
MarkupSafe==3.0.3
matrix-nio==0.25.2
mdurl==0.1.2
mpmath==1.3.0
multidict==6.7.0
networkx==3.6.1
numpy==2.4.0
nvidia-cublas-cu12==12.8.4.1
nvidia-cuda-cupti-cu12==12.8.90
nvidia-cuda-nvrtc-cu12==12.8.93
nvidia-cuda-runtime-cu12==12.8.90
nvidia-cudnn-cu12==9.10.2.21
nvidia-cufft-cu12==11.3.3.83
nvidia-cufile-cu12==1.13.1.3
nvidia-curand-cu12==10.3.9.90
nvidia-cusolver-cu12==11.7.3.90
nvidia-cusparse-cu12==12.5.8.93
nvidia-cusparselt-cu12==0.7.1
nvidia-nccl-cu12==2.27.5
nvidia-nvjitlink-cu12==12.8.93
nvidia-nvshmem-cu12==3.3.20
nvidia-nvtx-cu12==12.8.90
packaging==25.0
pillow==12.1.0
propcache==0.4.1
protobuf==6.33.2
psutil==7.2.1
pycparser==2.23
pycryptodome==3.23.0
pydantic==2.12.5
pydantic-settings==2.12.0
pydantic_core==2.41.5
PyGithub==2.8.1
Pygments==2.19.2
PyJWT==2.10.1
PyNaCl==1.6.2
python-dotenv==1.2.1
python-socks==2.8.0
PyYAML==6.0.3
referencing==0.37.0
regex==2025.11.3
requests==2.32.5
rich==14.2.0
rpds-py==0.30.0
safetensors==0.7.0
scipy==1.16.3
sentencepiece==0.2.1
shellingham==1.5.4
smmap==5.0.2
spandrel==0.4.1
SQLAlchemy==2.0.45
sympy==1.14.0
tokenizers==0.22.1
toml==0.10.2
torch==2.9.1
torchaudio==2.9.1
torchsde==0.2.6
torchvision==0.24.1
tqdm==4.67.1
trampoline==0.1.2
transformers==4.57.3
triton==3.5.1
typer==0.21.1
typing-inspection==0.4.2
typing_extensions==4.15.0
unpaddedbase64==2.1.0
urllib3==2.6.2
uv==0.9.24
yarl==1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Core team dependency Core-Important

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants