Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requesting WinUI 0 (non-WinUI) components be build. For use by packaging CI matrix. #639

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Arlodotexe
Copy link
Member

This PR:

  • Introduces the concept of "WinUI 0" as possible parameter in our Build-Toolkit-Components.ps1 script, indicating that non-WinUI projects should be built.
  • Fixes the "skip building component" logic for WinUI 2 and 3 projects
  • Allows consuming repositories (Labs, mainline WCT) to build and package WinUI 0, 2 and 3 components concurrently in CI without race conditions or improperly skipped components.

Prerequisite PR: CommunityToolkit/Tooling-Windows-Submodule#258

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@Arlodotexe Arlodotexe merged commit f8e015d into main Feb 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants