Skip to content

Add .NET 10 Support #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 51 commits into
base: main
Choose a base branch
from
Draft

Add .NET 10 Support #2902

wants to merge 51 commits into from
+787 −2,797

Conversation

@TheCodeTraveler
Copy link
Collaborator

@TheCodeTraveler TheCodeTraveler commented Oct 7, 2025 •
edited
Loading

Description of Change

This PR adds support for .NET 10

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

This PR will be merged when .NET 10 GAs in November 2025

Breaking Changes

  • .NET 10 Required
  • Removed Deprecated IPopup
  • Removed Deprecated MauiPopup
  • Removed Deprecated PopupHandler
  • Removed Deprecated PopupExtensions

@TheCodeTraveler TheCodeTraveler added the breaking change This label is used for PRs that include a breaking change label Oct 7, 2025
VladislavAntonyuk
VladislavAntonyuk reviewed Oct 8, 2025
View reviewed changes
src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpAnalyzerVerifier`1+Test.cs
{
#if NET9_0
#if NET10_0
ReferenceAssemblies = Microsoft.CodeAnalysis.Testing.ReferenceAssemblies.Net.Net90;
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update net10 here?

Copy link
Collaborator Author

@TheCodeTraveler TheCodeTraveler Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! We're waiting on Microsoft to release support for testing Analyzers with .NET 10. Microsoft.CodeAnalysis.Testing.ReferenceAssemblys.Net.Net100 hasn't yet been released.

For now, the Analyzer tests all fail.

I assume (hope) Microsoft will push support for this before .NET 10 GAs.

src/CommunityToolkit.Maui.Analyzers.UnitTests/Verifiers/CSharpCodeFixVerifier`2+Test.cs
{
#if NET9_0
#if NET10_0
ReferenceAssemblies = Microsoft.CodeAnalysis.Testing.ReferenceAssemblies.Net.Net90;
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference assemblies net10?

Copy link
Collaborator Author

@TheCodeTraveler TheCodeTraveler Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! We're waiting on Microsoft to release support for testing Analyzers with .NET 10. Microsoft.CodeAnalysis.Testing.ReferenceAssemblys.Net.Net100 hasn't yet been released.

For now, the Analyzer tests all fail.

I assume (hope) Microsoft will push support for this before .NET 10 GAs.

TheCodeTraveler and others added 18 commits October 9, 2025 14:54
@TheCodeTraveler
Remove AOT
e271c71
@TheCodeTraveler
Update to .NET 10 RC 2
c4cc7d7
@TheCodeTraveler
Update NuGet Packages
7ad3990
@TheCodeTraveler
Merge branch 'main' into Update-to-NET-10
a8fffa1
@TheCodeTraveler
Update NuGet packages
6db0619
@TheCodeTraveler
Merge branch 'main' into Update-to-NET-10
e4f283d
@TheCodeTraveler
Merge branch 'main' into Update-to-NET-10
3376442
@TheCodeTraveler
Remove [RequiresUnreferencedCode]
05a0a11
@TheCodeTraveler
Remove <NoWarn>CsWinRT1028
5f38f13
@TheCodeTraveler
Increase to JDK 21
e447a65
@TheCodeTraveler
Merge branch 'main' into Update-to-NET-10
8c9402b
@TheCodeTraveler
Remove NextMauiPackageVersion
f8febd1 
This should no longer be necessary now that we don't have internal access to MAUI
@ne0rrmatrix
sample apps builds
c029aa3
@ne0rrmatrix
Update for .NET MAUI compatibility and .NET 10 support
8f49d50 
- Added conditional compilation for .NET 10 in `CSharpAnalyzerVerifier`.
- Updated `XmlnsDefinition` attributes for .NET MAUI compatibility.
- Upgraded `Xamarin.AndroidX.Media3` packages to version 1.8.0.
- Added `using` directives for `Microsoft.Maui` namespaces across files.
- Adjusted platform-specific code to use updated APIs (e.g., `session.PlatformToken`).
- Included Android resource `textureview.xml` in the project.
@ne0rrmatrix
Temp fix for AllowMissingPrunePackageData to true
7827462
@ne0rrmatrix
Add AllowMissingPrunePackageData to resolve issues. This will need …
8710216 
…to be removed before shipping.
@ne0rrmatrix
Fix Tizen IDisposable in CamerViewHandler
989d5e9
@ne0rrmatrix
Fix Tizen?
6cbf841
This was referenced Oct 28, 2025
Merged
Closed
ne0rrmatrix and others added 20 commits November 4, 2025 14:56
@ne0rrmatrix
Adopt Xaml Source Generation
f6975da
@ne0rrmatrix
Merge branch 'main' into Update-to-NET-10
66bf811
@ne0rrmatrix
Merge branch 'CommunityToolkit:Update-to-NET-10' into Update-to-NET-10
0afa114
@TheCodeTraveler
Fix Microsoft.Extensions.Logging.Debug dependency
2a456ae
@TheCodeTraveler
Fix Nullable Type Errors
2a01ee0
@TheCodeTraveler
Build CommunityToolit.Maui.csproj instead of `CommunityToolkit.Maui…
c799b2d 
….sln`

This will allow us to isolate build errors in the pipeline currently being caused by `CommunityToolit.Maui.Analyzers.UnitTests`
@TheCodeTraveler
Fix .NET 10 Warnings
6f53910
@JoonghyunCho
Fix Tizen build errors for upgrading NET10 (#2928)
f14b77b
@TheCodeTraveler
dotnet format
2781421
@TheCodeTraveler
Add Latest NuGet Version
4bbe434
@TheCodeTraveler
Fix namespace
2fe3937
@TheCodeTraveler
Merge branch 'Update-to-NET-10' of https://github.com/CommunityToolki…
6dc00b2 
…t/Maui into Update-to-NET-10
@TheCodeTraveler
FixTizen Build Errors
6b2c4d1
@TheCodeTraveler
Add new keyword functionality to `BindablePropertyAttributeSourceGe…
52be289 
…nerator`
@TheCodeTraveler
Update BadgeImplementation.tizen.cs
1d7128f
@TheCodeTraveler
Add Fix for Android StatusBarBehavior on Android 35
b5add8a 
#2533 (comment)
@TheCodeTraveler
Merge branch 'Update-to-NET-10' of https://github.com/CommunityToolki…
a840aad 
…t/Maui into Update-to-NET-10
@TheCodeTraveler
Update NuGet Packages
ec0e53a
@TheCodeTraveler
Remove NuGet Package References Fixing Vulnerabilities
054f390
@ne0rrmatrix
Merge branch 'main' into Update-to-NET-10
51866ed
@ne0rrmatrix
Copy link
Contributor

ne0rrmatrix commented Nov 6, 2025

Looks like there is runtime issues still for Android and iOS/macOS. The issue is with FlyoutBackgroundColor and using AppThemeBinding to set light and dark in AppShell.xaml. The AppThemeBinding is not working with the new XAML SourceGen when you nest Bindings.

ATM I cannot run android or iOS without removing AppThemeBinding from AppShell.xaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladislavAntonyuk VladislavAntonyuk VladislavAntonyuk left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

breaking change This label is used for PRs that include a breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NET10] Switch to public MAUI types for AvatarView

4 participants

@TheCodeTraveler @ne0rrmatrix @VladislavAntonyuk @JoonghyunCho