Make peace between modal navigation and popups #2919
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where popups opened inside modal pages fail to display correctly due to navigation bar interference. The fix removes the navigation bar from popup pages and implements proper modal stack traversal to locate and close popups that are wrapped in navigation containers.
Key Changes:
- Explicitly disables the navigation bar for popup pages to prevent UI conflicts
- Adds a
FindPopupPage()method to handle closing popups that are nested within page containers (e.g., NavigationPage) - Removes unused imports to clean up the code
added 2 commits
October 31, 2025 00:14
pictos
force-pushed
the
pj/fix-modal-on-popups
branch
from
f69560f to
d70a248
Compare
| { | ||
| throw new PopupNotFoundException(); | ||
| await FindPopupPage(); | ||
| return; |
There was a problem hiding this comment.
Should we call PopupClosed event here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removed the NavigationBar and make sure the Close will work. When you open a Popup inside a ModalPage the Popup will not show on ModalStack, what shows up is a
NavigationPageand the PopupPage will be itsContent.Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information