NetworkManager package and PAM stat files fixes

[shanedell]

NetworkManager package and PAM stat files fixes

• Use proper NetworkManager package for ubuntu2204 and ubuntu2404.
• Resolved issue where using the same register variable outside and inside the block was causing failures.

Description:

• Update logic to make sure the NetworkManager package for ubuntu2204 and ubuntu2404 is being installed.
  • The updated logic makes sure that if future products use platform_package_overrides.NetworkManager that package gets used.
• Resolved issue where using the same register variable outside and inside the block was causing failures.

Rationale:

• When testing the Ansible playbook for ubuntu2404 I ran into two issues:

  • The playbook was trying to install and look for the NetworkManager package called NetworkManager, however for ubuntu2204 and ubuntu2404 the correct package name is network-manager. This was noted in the product files, it just was not being overriden.
  • When only the register variable of result_pam_file_present was being used for both inside and outside of a block it would cause strange errors.

• Fixes NetworkManager package not overriden for ubuntu 22.04 and 24.04 #14038

[openshift-ci]

Hi @shanedell. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.