-
Notifications
You must be signed in to change notification settings - Fork 755
Add service_systemd-journal-upload_enabled to RHEL 10 CIS #14069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add rule `service_systemd-journal-upload_enabled` to RHEL 10 CIS profile. Aligns the RHEL 10 CIS profile with CIS RHEL 10 Benchmark v1.0.1. Resolves: https://issues.redhat.com/browse/OPENSCAP-6109
|
While you didn't write this rule on this PR you might double check it before we merge this. Seems something seems wrong. |
|
I have improved description and rationale |
|
The rule is also failing tests, is that something we expect? If you we should waive it. |
|
I have found that the service failed to start and in journal I can see this error: That happens because the service doesn't have the remote log host configured. That should be done as a part of the configuration for the preceding CIS requirement (6.2.2.1.2 Ensure systemd-journal-upload authentication is configured). But, that requirement is manual. Is it OK to keep the rule |
|
I assume there isn't a way for US to NA this until the URL is configured? |
|
I think it's possible, the URL is configured in a configuration file, that means we can write a CPE OVAL check for that. But, I think it isn't something we want, because the report showing that rule is evaluated as notapplicable will be misleading. The CIS says users should have the service enabled. If the rule fails, the users know that they're incompliant and can resolve it. If the rule resolves as notapplicable, the users can skip the requirement. I lean towards this solution: add a warning to the rule and waive it in contest. |
The service systemd-journal-upload fails to start if a remote log destination URL isn't configured in /etc/systemd/journal-upload.conf. The rule will be added to RHEL by: ComplianceAsCode/content#14069 See the discussion there.
|
I have add a warning and I have created a PR that adds a waiver to contest: RHSecurityCompliance/contest#481 |
|
@jan-cerny: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The service systemd-journal-upload fails to start if a remote log destination URL isn't configured in /etc/systemd/journal-upload.conf. The rule will be added to RHEL by: ComplianceAsCode/content#14069 See the discussion there.
|
/packit retest-failed |
Add rule
service_systemd-journal-upload_enabledto RHEL 10 CIS profile. Aligns the RHEL 10 CIS profile with CIS RHEL 10 Benchmark v1.0.1.Resolves: https://issues.redhat.com/browse/OPENSCAP-6109