Add the symlog(loglinglog) axis to the binning plugin #5534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbuibui
force-pushed
the
feat/symlog
branch
from
23bcf21 to
445e95d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a copysign function to PMAcc math.
Adds a symlog axis to the binning plugin (a Log-Lin-Log axis).
This axis has a symmetric linear region around zero which has a user configurable threshold (which is mapped to the range -1 to 1) and is logarithmic outside, with continuous transitions (but not necessarily smooth) at the threshold boundaries.
In the logarithmic range, the values are mapped with magnitude
1 + ln(abs(val)/linThreshold)with the same sign as val.NOTE The bins are defined as equidistant in the symlog space. I am not sure if this is the best way to define bins with this axis, maybe independently setting the number of bins in the linear and log regions is better or maybe something else.
I am currently open to suggestions.
Added tests for the symlog axis.