Skip to content

Make RTP View Not Awful #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2022
Merged

Make RTP View Not Awful #170

merged 5 commits into from
Sep 7, 2022

Conversation

jabbate19
Copy link
Collaborator

@jabbate19 jabbate19 commented Sep 7, 2022 •
edited
Loading

We don't need to see all user pools on login. Let us see our VMs and moves the pools to a different route (with a button up top)
image
image
image
Solves #161

@jabbate19 jabbate19 requested a review from WillNilges September 7, 2022 20:29
WillNilges
WillNilges reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few high-level questions about how some of this logic works.

@WillNilges
Copy link
Member

Have you tested this with a normal user account? We have a testing account on LDAP for this purpose.

WillNilges
WillNilges approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jabbate19 jabbate19 merged commit 50855e3 into ComputerScienceHouse:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillNilges WillNilges WillNilges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabbate19 @WillNilges