Stream inspector for destinations #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
changed the title
hariso
commented
Nov 11, 2022
hariso
changed the title
lovromazgon
reviewed
Nov 16, 2022
Contributor
lovromazgon
left a comment
lovromazgon
left a comment
There was a problem hiding this comment.
I tried it out and it worked, both through a websocket and gRPC, nice work! I think the PR needs some polish but we're definitely on the right track 🙌
Some comments that don't belong anywhere else:
- Stopping Conduit with an inspector is not possible, Conduit blocks until the client closes the connection.
- It's possible to start an inspector on a stopped pipeline, we should probably check the status and return an error if that's the case.
- Similarly it's possible to stop a pipeline and keep an inspector running, I'd also expect the inspector to stop in that case.
- While testing I was able to process up to 120 records per second (I used https://websocketking.com/), that feels a bit slow given that it's running on the same machine, am I expecting too much?
- I don't think we mentioned metrics in the design, but I think it would be nice to at least see the number of open inspector sessions on a connector / processor. WDYT? No need to do it in this PR.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
hariso
force-pushed
the
haris/stream-inspector-destination
branch
from
d2c99b2 to
1a94458
Compare
hariso
commented
Nov 21, 2022
lovromazgon
reviewed
Nov 21, 2022
Contributor
lovromazgon
left a comment
lovromazgon
left a comment
There was a problem hiding this comment.
Mostly just nitpicks, I think this is already looking very nice!
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
Co-authored-by: Lovro Mažgon <[email protected]>
…itIO/conduit into haris/stream-inspector-destination
This reverts commit 8f40c22.
lovromazgon
reviewed
Nov 29, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #732
Fixes #700
Quick checks: