use oneshot channel to bridge async and blocking-io tasks, this can avoid blocking task block async runtime #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pana
changed the title
|
retest this please |
Pana
force-pushed
the
feat/asyncBridge
branch
from
e329576 to
04913c5
Compare
|
retest this please |
Pana
changed the title
ChenxingLi
requested changes
Mar 3, 2025
There was a problem hiding this comment.
Reviewed 20 of 22 files at r1, all commit messages.
Reviewable status: 20 of 22 files reviewed, 1 unresolved discussion
crates/rpc/rpc-eth-impl/src/eth.rs line 1068 at r1 (raw file):
{ let self_clone = self.clone(); async move {
Why there are nested async closures?
Pana
commented
Mar 3, 2025
There was a problem hiding this comment.
Reviewable status: 20 of 22 files reviewed, 1 unresolved discussion (waiting on @ChenxingLi)
crates/rpc/rpc-eth-impl/src/eth.rs line 1068 at r1 (raw file):
Previously, ChenxingLi (Chenxing Li) wrote…
Why there are nested async closures?
It is required to use async closures to capture the cloned self, otherwise there will be a lifetime issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all underlying RPC handlers are essentially synchronous methods, which involve blocking I/O operations. This affects task scheduling in the asynchronous runtime, leading to performance degradation. This PR introduces a bridge that correctly spawns blocking I/O operations using
spawn_blockingand sends the results back via a oneshot channel after task completion.This PR will solve issue #3077
This change is