Feature/bump to last versions #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded gulp and related packages to their latest versions. - Replaced gulp-util with fancy-log and added gulp-clean-css. - Added new npm scripts for build, development, and versioning tasks. - Removed deprecated or outdated dependencies.
bruian
force-pushed
the
feature/bump-to-last-versions
branch
from
d6be35e to
2a4c935
Compare
…ess intervals - Moved lifecycleCallback and progressInterval to rendererOptions in virtualized_pivotui_example.html - Updated pivot.coffee to correctly handle lifecycleCallback and progressInterval from rendererOptions - Ensured asyncMode is properly passed to suboptions in pivot table rendering - Adjusted default options for rendererOptions to include progressInterval and lifecycleCallback - Disabled virtualization in certain contexts for better performance
…n and add footer totals - Removed the threshold option from the virtualized pivot UI example. - Updated pivotUI call to enable async mode for rendering. - Introduced column width measurement and application logic to ensure consistent widths across headers, data rows, and footers. - Added a new footer section to display column totals, enhancing the pivot table's functionality. - Removed the old totals row creation logic in favor of the new footer implementation. - Implemented flags to prevent update conflicts during row rendering.
- Added `autoHeight` option to virtualization settings to allow automatic height determination based on the pivot UI. - Implemented logic to calculate available height for the pivot table based on the pivot UI element's dimensions. - Updated renderer options to pass the pivot UI element for accurate height calculations. - Ensured backward compatibility by maintaining existing height settings when `autoHeight` is false.
bruian
force-pushed
the
feature/bump-to-last-versions
branch
from
46ca5e8 to
86c2e2f
Compare
- Adjusted height calculations for pivot UI elements to ensure proper rendering when virtualization is enabled. - Improved span size calculations to account for virtualized rows, ensuring headers are displayed correctly. - Applied column widths consistently across data rows and headers to prevent layout issues during virtualization. - Added comments for clarity on changes related to CSS styles and virtualization logic.
…ecycleCallback instead of lifecycleCallback
Removed the threshold condition from the virtualization check, simplifying the logic to only consider if virtualization is enabled. This change ensures that virtualization is applied whenever it is enabled, regardless of the total number of rows.
Updated the virtualization check to ensure it consistently uses the `opts.table.virtualization.enabled` property. This change clarifies the logic by moving the assignment of `shouldVirtualize` after the initial lifecycle call, ensuring that the correct value is used for the `isVirtualized` property in the render-started event.
bruian
force-pushed
the
feature/bump-to-last-versions
branch
from
43a0b81 to
c177b6d
Compare
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
- Introduced logic to calculate estimated visible rows when virtualization is enabled. - Added parameters for container height, row height, and buffer size to determine the number of visible rows. - Updated the render-started lifecycle event to include estimatedVisibleRows in the payload.
- Introduced logic to calculate estimated visible rows when virtualization is enabled. - Added parameters for container height, row height, and buffer size to determine the number of rows that can be displayed. - Included estimated visible rows in the render-started lifecycle event. - Added early return for rendering if the process is aborted by the user.
…ry object - Updated the handling of the "Rendering aborted by user" message to return the raw DOM element instead of a jQuery object in multiple locations within the pivot rendering logic. - This change ensures consistency in the return type when rendering is aborted, improving compatibility with the expected output format.
…ndering - Introduced `forceRefresh` option to allow forced rendering even after an abort. - Enhanced abort functionality to display a message and a refresh button when rendering is aborted. - Updated abort function to accept a message for more informative user feedback. - Adjusted rendering logic to conditionally handle abort states based on the `forceRefresh` option.
…ndering is aborted. Updated jQuery selectors for consistency.
bruian
force-pushed
the
feature/bump-to-last-versions
branch
from
29c7a82 to
5a78e90
Compare
- Added initialization of abortMessage to null in multiple locations to ensure consistent state management. - Removed redundant lines setting abortMessage to null where it was already initialized.
- Removed hardcoded threshold for virtualization. - Simplified calculation of estimated visible rows by directly using options for containerHeight, rowHeight, bufferSize, and headerHeight. - Improved readability and maintainability of the virtualization logic.
- Updated the metadata object to include estimatedVisibleRows in two instances within the callWithJQuery function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.