Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bitscrunch as linea indexers #966

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

heymanishjain
Copy link

No description provided.

Copy link

vercel bot commented Feb 5, 2025

@heymanishjain is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, mostly addressing capitalisation.

Could you please add a link to sidebars.js as well please? otherwise your page won't display in the sidebar.

thanks!

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2025 9:11am

@heymanishjain
Copy link
Author

Hi @jlwllmr as per your request we have made the changes and also removed the logo image can you please review this PR now

@jlwllmr
Copy link
Collaborator

jlwllmr commented Feb 11, 2025

@heymanishjain the link checker is failing because the linked-to sites have CAPTCHA. We can make the check pass by adding to mlc_config.json — I attempted to push up these changes but can't push to your branch. Could you please add the domains that are causing the check to fail?

image

Note that you don't need the full URL, just the domain — e.g. only https://docs.bitbrunch.com without the path to the specific page.

@heymanishjain
Copy link
Author

Hi @jlwllmr as requested I have added the URLs in mlc_config.json please review.
Thank You.

@jlwllmr
Copy link
Collaborator

jlwllmr commented Feb 11, 2025

@heymanishjain can you check the branch settings on your fork? I think there could be some protections in place that are preventing our GH Actions workflows from running.

@heymanishjain
Copy link
Author

Hi @jlwllmr can you verify now if GH Actions workflows are running or not? I did made some change
Thank You

@jlwllmr
Copy link
Collaborator

jlwllmr commented Feb 12, 2025

@heymanishjain thank you — unfortunately still no luck. leave it with me!

@heymanishjain
Copy link
Author

Hi @jlwllmr please let me know if there is anything I could do if not also let me know if you want me to fork the repo again and create a new PR as well

@jlwllmr
Copy link
Collaborator

jlwllmr commented Feb 13, 2025

@heymanishjain I can't push to your branch, which means I can't test if it's the conflicts that might be preventing the checks from running. If you'd be willing to resolve them, we could see if that is the issue?

@heymanishjain
Copy link
Author

Hi @jlwllmr there were conflicts which I have resolved can you please check if you are able to review this now and merge?

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating!

@heymanishjain
Copy link
Author

jlwllmr

Hi the requested changes missing bracket and moving the item to top in sidebar js is completed and I have push the code please review

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jlwllmr
Copy link
Collaborator

jlwllmr commented Feb 21, 2025

@heymanishjain link checker is still flagging a URL:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation - Add bitsCrunch Product documentation Under Data Indexers Section
2 participants