-
Notifications
You must be signed in to change notification settings - Fork 487
feat: GKR Add Instance #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tabaie
wants to merge
66
commits into
master
Choose a base branch
from
feat/gkr/add-instance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: GKR Add Instance #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the GKR API so that defining the circuit and assigning instances are separated. It removes the necessity of defining hints for the output and deferred "finalize" functions.
Remove the
Printlnfunction in favor ofGetValue.gkrgates.Registernow checks if a gate of the same name has already been registered. If so, it compares the gates and returns an error if they are not equal. If they are equal, it returnsfalse, nil.Remove all logic pertaining to reordering of wires and instances.
Unless the user explicitly provides their own initial challenge, automatically use all input and output of the circuit as initial Fiat-Shamir challenge.
Rename
GkrCompressionstoGkrPermutationsto correctly reflect its function. (Note: a future PR should implement compressions instead and revert the name change)A benchmark for gkr-poseidon2
Note
Adds a new GKR API with Compile/AddInstance and GetValue, refactors hint/solver plumbing, strengthens gate registration (dup/equality and curve constraints), and updates generators/tests/examples accordingly.
API.NewInput,Circuit.Compile,Circuit.AddInstance, andCircuit.GetValue; removesImport/Series/Solve/SolutionandPrintln.internal/gkr/gkrhints) withGetAssignment,Solve, andProvehints; solvers now override these hints accordingly.ComputeLogNbInstancesfor proof deserialization.gkrgates.Registeroptions now validate and may error; prevents duplicate conflicting registrations and supports curve-allowlists; adds equality check for gate functions.MulAccto multiply (was add); addEqualGateFunctionhelper; update generated solver hints to new flow.ExtendRepeatLast, etc.).Written by Cursor Bugbot for commit 61302f4. This will update automatically on new commits. Configure here.