fix: propagate ReadFrom errors in generated r1cs tests #1588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace t.Fatal(nil) with t.Fatal(err) in r1cs.go.tmpl so generated R1CS serialization tests correctly report reconstruction errors instead of discarding them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Generated R1CS serialization tests were using
t.Fatal(nil)instead oft.Fatal(err)when handling ReadFrom errors, causing tests to fail without proper error context.
Solution
ixed the generator template
internal/generator/backend/template/representations/tests/r1cs.go.tmplto use
t.Fatal(err)and regenerated all affected test files.Files Changed
internal/generator/backend/template/representations/tests/r1cs.go.tmplconstraint/*/r1cs_test.gofilesTesting