refactor: revamp snap onHomePage handler
#345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
…-on-homepage-handle
|
|
khanti42
requested changes
Sep 20, 2024
Comment on lines
+123
to
+124
| !currentNetwork || | ||
| currentNetwork.chainId !== STARKNET_MAINNET_NETWORK.chainId |
There was a problem hiding this comment.
Suggested change
| !currentNetwork || | |
| currentNetwork.chainId !== STARKNET_MAINNET_NETWORK.chainId | |
| !currentNetwork || ( | |
| currentNetwork.chainId !== STARKNET_MAINNET_NETWORK.chainId && | |
| currentNetwork.chainId !== STARKNET_SEPOLIA_TESTNET_NETWORK.chainId | |
| ) |
| !currentNetwork || | ||
| currentNetwork.chainId !== STARKNET_MAINNET_NETWORK.chainId | ||
| ) { | ||
| return STARKNET_SEPOLIA_TESTNET_NETWORK; |
There was a problem hiding this comment.
Suggested change
| return STARKNET_SEPOLIA_TESTNET_NETWORK; | |
| return STARKNET_MAINNET_NETWORK; |
| async getCurrentNetwork(state?: SnapState): Promise<Network> { | ||
| const { currentNetwork } = state ?? (await this.get()); | ||
|
|
||
| // Make sure the current network is either Sepolia testnet or Mainnet. By default it will be Sepolia testnet. |
There was a problem hiding this comment.
Suggested change
| // Make sure the current network is either Sepolia testnet or Mainnet. By default it will be Sepolia testnet. | |
| // Make sure the current network is either Sepolia testnet or Mainnet. By default it will be Mainnet. |
| @@ -173,15 +174,27 @@ describe('NetworkStateManager', () => { | |||
| expect(result).toStrictEqual(STARKNET_MAINNET_NETWORK); | |||
| }); | |||
|
|
|||
| it('returns null if the current network is null or undefined', async () => { | |||
| it('returns sepolia testnet if the current network is null or undefined', async () => { | |||
There was a problem hiding this comment.
Suggested change
| it('returns sepolia testnet if the current network is null or undefined', async () => { | |
| it('returns mainnet if the current network is null or undefined', async () => { |
| await mockState({ | ||
| networks: [STARKNET_MAINNET_NETWORK, STARKNET_SEPOLIA_TESTNET_NETWORK], | ||
| }); | ||
|
|
||
| const stateManager = new NetworkStateManager(); | ||
| const result = await stateManager.getCurrentNetwork(); | ||
|
|
||
| expect(result).toBeNull(); | ||
| expect(result).toStrictEqual(STARKNET_SEPOLIA_TESTNET_NETWORK); |
There was a problem hiding this comment.
Suggested change
| expect(result).toStrictEqual(STARKNET_SEPOLIA_TESTNET_NETWORK); | |
| expect(result).toStrictEqual(STARKNET_MAINNET_NETWORK); |
| expect(result).toStrictEqual(STARKNET_SEPOLIA_TESTNET_NETWORK); | ||
| }); | ||
|
|
||
| it('returns sepolia testnet if the current network is neither mainnet or sepolia testnet', async () => { |
There was a problem hiding this comment.
Suggested change
| it('returns sepolia testnet if the current network is neither mainnet or sepolia testnet', async () => { | |
| it('returns mainnet if the current network is neither mainnet or sepolia testnet', async () => { |
| const stateManager = new NetworkStateManager(); | ||
| const result = await stateManager.getCurrentNetwork(); | ||
|
|
||
| expect(result).toStrictEqual(STARKNET_SEPOLIA_TESTNET_NETWORK); |
There was a problem hiding this comment.
Suggested change
| expect(result).toStrictEqual(STARKNET_SEPOLIA_TESTNET_NETWORK); | |
| expect(result).toStrictEqual(STARKNET_MAINNET_NETWORK); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a controller to handle the request in onHomePage
This PR also update the network state manager to return an default network if the current network is undefined
Requirement:
Requires this PR to be merged first:
snapUtilsfunction -dappUrl#344