Cleanup gossip params#10956
Open
tbenr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Low Risk
Refactor preserves numeric limits; the only behavioral delta is explicitly configuring maxIDontWantMessageIds to 5000, which is a bounded gossip validation limit.
Overview
Refactors
LibP2PParamsFactoryso gossip inbound RPC repeated-field limits use namedprivate static finalconstants instead of inline literals, matching the existingMAX_SUBSCRIPTIONS_PER_MESSAGEpattern.Also sets
maxIDontWantMessageIdsto 5000 on the gossip params builder (new wiring in this change). A unit test asserts the published-message, subscription, graft/prune, IHAVE/IWANT, and IDONTWANT limits still match the expected values.Reviewed by Cursor Bugbot for commit 58ca06d. Bugbot is set up for automated code reviews on this repo. Configure here.