Remove eth1 deposit cli options#10957
Open
gfukushima wants to merge 11 commits into
Open
Conversation
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Removes the legacy web3j-based Eth1/PoW deposit-log fetching stack and the now-dead Eth1 provider stack: DepositFetcher, DepositProcessingController, Eth1DepositManager, Web3jEth1Provider/Web3jInSyncCheck, MinimumGenesisTimeBlockFinder, TimeBasedEth1HeadTracker, Eth1BlockFetcher, the Eth1Provider decorator stack, and services/powchain Eth1Providers/Eth1ProviderMonitor. PowchainService is reduced to loading the finalized deposit-tree snapshot (from the bundled file or the database) and seeding the deposit provider via onInitialDepositTreeSnapshot, without any web3j usage. DepositProvider then relies on that snapshot plus in-protocol (EIP-6110) deposits. Eth1-derived genesis is no longer supported, so initGenesisHandler now requires an initial anchor state (custom state, checkpoint sync, or interop) instead of subscribing a GenesisHandler to the Eth1 chain. Part of Consensys#10876.
Removes the now-obsolete production CLI options tied to runtime Eth1 deposit polling (--eth1-endpoints/--eth1-endpoint, --eth1-deposit-contract-max-request-size, --Xeth1-missing-deposits-event-logging-enabled, --Xdeposit-contract-logs-syncing-enabled) and the corresponding PowchainConfiguration plumbing. Documented in CHANGELOG. Part of Consensys#10876.
# Conflicts: # data/serializer/src/main/java/tech/pegasys/teku/api/migrated/BuilderStatus.java # eth-reference-tests/src/referenceTest/java/tech/pegasys/teku/reference/phase0/ssz_generic/containers/SszUInt32.java # ethereum/dataproviders/src/main/java/tech/pegasys/teku/dataproviders/lookup/RecentlyValidatedDataColumnSlotProvider.java # ethereum/dataproviders/src/test/java/tech/pegasys/teku/dataproviders/lookup/RecentlyValidatedDataColumnSlotProviderTest.java # services/powchain/src/main/java/tech/pegasys/teku/services/powchain/PowchainService.java # services/powchain/src/test/java/tech/pegasys/teku/services/powchain/PowchainServiceTest.java # teku/src/main/java/tech/pegasys/teku/services/BeaconNodeServiceController.java
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…emoving, just for consistency Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
rolfyone
approved these changes
Jul 12, 2026
rolfyone
left a comment
rolfyone
left a comment
Contributor
There was a problem hiding this comment.
LGTM, we'll either want to 'doc-change-required' or raise a PR to cleanup docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This is a follow up PR to remove the CLI options previously used to tweak configurations related to the old mechanism to fetch deposits.
Fixed Issue(s)
Part of #10876
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Medium Risk
Breaking CLI and config surface for deposit ingestion; misconfigured upgrades could fail startup or rely on snapshot/EIP-6110 paths operators must understand.
Overview
Breaking change: Documents and completes removal of the legacy web3j Eth1 deposit-log path. Operators can no longer pass
--eth1-endpoints/--eth1-endpoint,--eth1-deposit-contract-max-request-size, or hidden flags for deposit contract log syncing and missing-deposit logging.DepositOptionsnow only wires deposit snapshot settings (--deposit-snapshot-enabled,--Xdeposit-snapshot).PowchainConfigurationdrops the related builder fields and getters (log block range, missing-deposit logging, contract log syncing).Acceptance DSL
withDepositsFromsets only the deposit contract address (no Eth1 JSON-RPC URL). Tests and sample YAML configs are updated accordingly; Eth1-endpoint-focused tests are removed fromDepositOptionsTest.Reviewed by Cursor Bugbot for commit 80440c0. Bugbot is set up for automated code reviews on this repo. Configure here.