Update Schema Registry and adopt progressive ssz in GLOAS#10966
Open
tbenr wants to merge 10 commits into
Open
Conversation
22fa4a5 to
8a33a4e
Compare
8a33a4e to
ebcedf3
Compare
Contributor
|
mixed bag from claude here so i'll just post its output Missing coverage:
Good coverage added:
Minor
Summary The overall approach is correct and follows established patterns. The most important items to address before merge are:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit f3c61bb. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

fixes #10930
fixes #10931
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
High Risk
Large consensus-layer schema and Gloas state-upgrade changes affect merkleization, fork transitions, and networking limits; incorrect rematerialization or progressive list wiring could break interoperability at the Gloas fork.
Overview
This PR wires Gloas to progressive SSZ (EIP-7916): bounded block-body and execution lists become
SszProgressiveListSchema, Gloas containers use active field masks, and blob/data-column schemas split into milestone-specific types (e.g.BlobKzgCommitmentsSchemaGloas,DataColumnSchemaGloas) behind shared interfaces.Schema registry usage expands so transactions, deposit/execution-request lists, aggregation bits, and similar types are resolved from the registry instead of being built inline with config max lengths.
DepositProviderdrops its local deposits schema cache and usesgetDepositsSchema()from slot schema definitions. Execution payload schemas takeSchemaRegistryand exposeSszByteListSchema<Transaction>(plusProgressiveTransactionSchemafor Gloas).Gloas fork transition rematerialises list fields when merkleization changes via
BeaconStateListFieldMigration(SSZ round-trip) andcopyCommonFieldsFromSourceUsingTargetSchemas.BeaconStateSchemaGloasand commonvalidators/balancesfields use progressive lists at Gloas+.Networking/config: Gloas adds payload size constants and optional
networkSszLengthBytesUpperBoundon several gossip types. Light client getsLightClientBootstrapSchemaGloaswith a Gloas sync-committee gindex.DelegatingSpecConfigElectra.getMaxAttestations()now returns the Electra cap.Reviewed by Cursor Bugbot for commit d556f14. Bugbot is set up for automated code reviews on this repo. Configure here.