Implement dynamic window title management based on active dock tabs #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous method could have led to potential memory leaks, as a panel could have kept a reference to its sibling after it had been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this pull request resolves #3480.
It adds a class that sets up listeners that listen to to tab focus events, which update the window title to include the focused tab.
The format of the window title is configurable with the message resource
WindowTitleFormat=CS-Studio: %s, with %s being replaced by the active tab name. In the edge case where the main window has no active tabs, it falls back toFixedTitle.It also slightly improves the logic determining which panel is currently active when splitting and merging them, as before it could lead to situations where a tab that no longer existed would still be deemed the "active tab".