CSSTUDIO-1355 Add Waterfall Plot widget to Phoebus. #3520
Conversation
|
Does it go left/right with time? Waterfall plots tend to go up/down with time, https://en.wikipedia.org/wiki/Waterfall_plot |
| </dependency> | ||
| <dependency> | ||
| <groupId>io.fair-acc</groupId> | ||
| <artifactId>chartfx</artifactId> |
There was a problem hiding this comment.
Can you add the new dependency to dependencies/phoebus-target/pom.xml?
There was a problem hiding this comment.
It's possible, but isn't it preferable that only the module waterfallplot includes it? If one builds Phoebus without the Waterfall plot, then there is no need to include the new dependency in the build.
There was a problem hiding this comment.
See https://github.com/ControlSystemStudio/phoebus/tree/master/dependencies#readme
This is about establishing a target platform, a list of all the dependencies, for use with Eclipse, ant, make, .. whatever you want to use. If you limit the build tools to maven, then you're of course correct.
There was a problem hiding this comment.
I have added the dependency to dependencies/phoebus-target/pom.xml: 7bc8075
Which axis is the "time axis" is configurable using the "Time Axis" widget property. |
|
I have changed the default to be time on the y-axis. The x-axis represents "now" and the data-points travel upwards in the plot into the "past". |
This pull request adds a new Waterfall Plot widget to Phoebus:
The intended usage of the widget is to display the evolution of a waveform or of a number of (compatible) PVs over time. The widget plots the values of the waveform or the list of PVs from a configurable amount of time in the past until the current moment. For simplicity, the time is always displayed in UTC in the initial implementation. The plot is updated once per second.
The implementation of the widget uses the ChartFX [1] library for its implementation.
I have added the widget to the Maven-build files by adding it to the
pom.xmlfile forphoebus-product. At the moment, it is enabled by default in the pull request. Would it be preferable that it is disabled by default?Unfortunately, I am not familiar withe the Ant build system, and I have therefore not added it to this build system. Help to add it to the Ant build system is welcome.
One limitation is that the widget currently does not allow for dynamically changing the connected PV(s) when it is running.
When testing the widget and the widget doesn't display any values, it may be helpful to check the setting "Z-axis min & max" to make sure it is correctly set.
[1] https://github.com/fair-acc/chart-fx