Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

fix: add email type attribute to email input fields #398

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Roshanjossey
Copy link
Contributor

closes Couchers-org/couchers#4135

Web frontend checklist

  • Formatted my code with make format
  • There are no warnings from make lint
  • There are no console warnings when running the app
  • Added any new components to storybook
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

@bakeiro
Copy link
Contributor

bakeiro commented Jan 26, 2024

hey! you can add me to reviewer to check the PRs (if you want it), also I wrote you in LinkedIn :)

@bakeiro bakeiro self-requested a review January 26, 2024 09:24
Copy link
Contributor

@bakeiro bakeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested that this doesn't autocapitalize the first letter? if yes then approved :)

@bakeiro bakeiro self-requested a review January 26, 2024 10:49
Copy link
Contributor

@bakeiro bakeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and seems to not make a difference

@bakeiro
Copy link
Contributor

bakeiro commented Jan 26, 2024

couldn't reproduce it in next neither prod https://couchers.org/password-reset, might be already solved?

@Roshanjossey
Copy link
Contributor Author

@bakeiro, how did you test it?

@bakeiro
Copy link
Contributor

bakeiro commented Feb 7, 2024

@bakeiro, how did you test it?

Tried to get the branch locally but couldn't get it (not sure why) so just copied the code modifications and tried to see that the uppercase problem was solved but seems that the code changed didn't affect it. (also I saw that in production doesn't happen either the uppercase problem)

@Roshanjossey
Copy link
Contributor Author

I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.

@bakeiro
Copy link
Contributor

bakeiro commented Feb 15, 2024

I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning.

yeah yeah, that I understood, but where? every time I put the password (android or iOS) isn't capitalized by default, email yes, but not password

@bakeiro
Copy link
Contributor

bakeiro commented Feb 15, 2024

test

keyboard it's missing in the pic 😅, but for me the first letter ISN'T capitalized by default... maybe happens in other iOS devices? if that's the case then we can merge it :)

[approved just in case]

Copy link
Contributor

@bakeiro bakeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@aapeliv aapeliv added the web label Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset input field normalization
3 participants