-
Notifications
You must be signed in to change notification settings - Fork 8
fix: add email type attribute to email input fields #398
base: develop
Are you sure you want to change the base?
fix: add email type attribute to email input fields #398
Conversation
hey! you can add me to reviewer to check the PRs (if you want it), also I wrote you in LinkedIn :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested that this doesn't autocapitalize the first letter? if yes then approved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and seems to not make a difference
couldn't reproduce it in next neither prod https://couchers.org/password-reset, might be already solved? |
@bakeiro, how did you test it? |
Tried to get the branch locally but couldn't get it (not sure why) so just copied the code modifications and tried to see that the uppercase problem was solved but seems that the code changed didn't affect it. (also I saw that in production doesn't happen either the uppercase problem) |
I can still reproduce it on mobile. So, the bug is not that we're doing something to capitalize first letter. It's a native behaviour on input fields on mobile to show keyboard with capital letter in the beginning. |
yeah yeah, that I understood, but where? every time I put the password (android or iOS) isn't capitalized by default, email yes, but not password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
closes Couchers-org/couchers#4135
Web frontend checklist
make format
make lint