Skip to content

Commit

Permalink
Merge pull request #340 from Countly/v1-embedding-drop
Browse files Browse the repository at this point in the history
V1 embedding drop
  • Loading branch information
turtledreams authored Feb 17, 2025
2 parents fe59cee + b1baf69 commit 13d2caf
Show file tree
Hide file tree
Showing 10 changed files with 24 additions and 16 deletions.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
## 25.1.1
* Removed Android v1 embedding support

* Underlying Android SDK version is 25.1.1
* Underlying iOS SDK version is 25.1.1
* Underlying Web SDK version is 25.1.0

## 25.1.0
* Added experimental support for the web platform in the Countly Flutter SDK. Some functionalities are not yet fully supported. Below is the list of limitations for the web platform:
* Hybrid sessions are the default; full manual sessions are not supported.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.MethodChannel.MethodCallHandler;
import io.flutter.plugin.common.MethodChannel.Result;
import io.flutter.plugin.common.PluginRegistry.Registrar;
// import io.flutter.plugin.common.PluginRegistry.Registrar;

import ly.count.android.sdk.Countly;
import ly.count.android.sdk.CountlyConfig;
Expand Down Expand Up @@ -67,7 +67,7 @@
*/
public class CountlyFlutterPlugin implements MethodCallHandler, FlutterPlugin, ActivityAware, DefaultLifecycleObserver {
private static final String TAG = "CountlyFlutterPlugin";
private final String COUNTLY_FLUTTER_SDK_VERSION_STRING = "25.1.0";
private final String COUNTLY_FLUTTER_SDK_VERSION_STRING = "25.1.1";
private final String COUNTLY_FLUTTER_SDK_NAME = "dart-flutterb-android";
private final String COUNTLY_FLUTTER_SDK_NAME_NO_PUSH = "dart-flutterbnp-android";

Expand Down Expand Up @@ -141,13 +141,13 @@ public final int resultResponder(RequestResult rResult) {
//----------PLUGIN REGISTRATION (FlutterPlugin)-------------------

// Required for pre Flutter 1.12 projects
public static void registerWith(Registrar registrar) {
final CountlyFlutterPlugin instance = new CountlyFlutterPlugin();
instance.activity = registrar.activity();
final Context __context = registrar.context();
instance.onAttachedToEngineInternal(__context, registrar.messenger());
log("registerWith", LogLevel.INFO);
}
// public static void registerWith(Registrar registrar) {
// final CountlyFlutterPlugin instance = new CountlyFlutterPlugin();
// instance.activity = registrar.activity();
// final Context __context = registrar.context();
// instance.onAttachedToEngineInternal(__context, registrar.messenger());
// log("registerWith", LogLevel.INFO);
// }

// Called from Android embedding v2
@Override
Expand Down
1 change: 1 addition & 0 deletions example/android/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ gradle-wrapper.jar
/gradlew
/gradlew.bat
/local.properties
/app/.cxx/
GeneratedPluginRegistrant.java

# Remember to never publicly share your keystore.
Expand Down
2 changes: 1 addition & 1 deletion example/integration_test/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ void testCommonRequestParams(Map<String, List<String>> requestObject) {
expect(
requestObject['sdk_name']?[0],
"dart-flutterb-${kIsWeb ? 'web' : Platform.isIOS ? 'ios' : 'android'}");
expect(requestObject['sdk_version']?[0], '25.1.0');
expect(requestObject['sdk_version']?[0], '25.1.1');
expect(
requestObject['av']?[0],
kIsWeb
Expand Down
2 changes: 1 addition & 1 deletion ios/Classes/CountlyFlutterPlugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ @interface CountlyPersistency ()

CLYPushTestMode const CLYPushTestModeProduction = @"CLYPushTestModeProduction";

NSString *const kCountlyFlutterSDKVersion = @"25.1.0";
NSString *const kCountlyFlutterSDKVersion = @"25.1.1";
NSString *const kCountlyFlutterSDKName = @"dart-flutterb-ios";
NSString *const kCountlyFlutterSDKNameNoPush = @"dart-flutterbnp-ios";

Expand Down
2 changes: 1 addition & 1 deletion ios/countly_flutter.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
Pod::Spec.new do |s|
s.name = 'countly_flutter'
s.version = '25.1.0'
s.version = '25.1.1'
s.summary = 'Countly is an innovative, real-time, open source mobile analytics platform.'
s.homepage = 'https://github.com/Countly/countly-sdk-flutter-bridge'
s.social_media_url = 'https://twitter.com/gocountly'
Expand Down
2 changes: 1 addition & 1 deletion lib/src/web/plugin_config.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class CountlyFlutterPluginConfig {
static const String SDK_VERSION_STRING = '25.1.0';
static const String SDK_VERSION_STRING = '25.1.1';
static const String SDK_NAME = 'dart-flutterb-web';
static const String WEB_SDK_URL = 'https://cdn.jsdelivr.net/npm/[email protected]/lib/countly.min.js';
}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: countly_flutter
description: Countly is an innovative, real-time, open source mobile analytics and push notifications platform.
version: 25.1.0
version: 25.1.1
homepage: https://support.count.ly/hc/en-us/articles/360037944212
repository: https://github.com/Countly/countly-sdk-flutter-bridge
issue_tracker: https://github.com/Countly/countly-sdk-flutter-bridge/issues
Expand Down
2 changes: 1 addition & 1 deletion scripts/no-push-files/countly_flutter_np.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#
Pod::Spec.new do |s|
s.name = 'countly_flutter_np'
s.version = '25.1.0'
s.version = '25.1.1'
s.summary = 'Countly is an innovative, real-time, open source mobile analytics platform.'
s.homepage = 'https://github.com/Countly/countly-sdk-flutter-bridge'
s.social_media_url = 'https://twitter.com/gocountly'
Expand Down
2 changes: 1 addition & 1 deletion scripts/no-push-files/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: countly_flutter_np
description: Countly is an innovative, real-time, open source mobile analytics. This plugin is a flavour of the SDK without push notifications.

version: 25.1.0
version: 25.1.1
homepage: https://support.count.ly/hc/en-us/articles/360037944212-Flutter
repository: https://github.com/Countly/countly-sdk-flutter-bridge
issue_tracker: https://github.com/Countly/countly-sdk-flutter-bridge/issues
Expand Down

0 comments on commit 13d2caf

Please sign in to comment.