Skip to content

Conversation

@adi-herwana-nus
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-adds a sidebar item title for "scholaistic assessments" (Role-Playing Assessments) that was previously removed or missing from the codebase. The changes add translation support across multiple languages.

  • Adds translation entries for the sidebar item title in English, Korean, and Chinese
  • Adds the corresponding translation key and mapper entry in the TypeScript translations file

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
client/locales/en.json Adds English translation for "Role-Playing Assessments" sidebar item
client/locales/ko.json Adds Korean translation for "롤플레잉 평가" sidebar item
client/locales/zh.json Adds Chinese translation for "角色扮演评估" sidebar item
client/app/bundles/course/translations.ts Adds translation message descriptor and legacy sidebar key mapper entry for scholaistic assessments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adi-herwana-nus
Copy link
Contributor Author

@copilot "scholaistic" refers to https://github.com/ai-cet/scholaistic, one of our sister products.

The spellings are intentional.

Copy link

Copilot AI commented Jan 7, 2026

@adi-herwana-nus I've opened a new pull request, #8197, to work on those changes. Once the pull request is ready, I'll request review from you.

@adi-herwana-nus
Copy link
Contributor Author

@copilot I've resolved your comments.

Copy link

Copilot AI commented Jan 7, 2026

@adi-herwana-nus I've opened a new pull request, #8198, to work on those changes. Once the pull request is ready, I'll request review from you.

@adi-herwana-nus adi-herwana-nus merged commit 01a4bb7 into master Jan 7, 2026
10 checks passed
@adi-herwana-nus adi-herwana-nus deleted the adi/add-missing-scholaistic-label branch January 7, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants