-
Notifications
You must be signed in to change notification settings - Fork 78
feat(translations): re-add scholaistic sidebar item title #8196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0d7ebe3 to
0ff710c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR re-adds a sidebar item title for "scholaistic assessments" (Role-Playing Assessments) that was previously removed or missing from the codebase. The changes add translation support across multiple languages.
- Adds translation entries for the sidebar item title in English, Korean, and Chinese
- Adds the corresponding translation key and mapper entry in the TypeScript translations file
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| client/locales/en.json | Adds English translation for "Role-Playing Assessments" sidebar item |
| client/locales/ko.json | Adds Korean translation for "롤플레잉 평가" sidebar item |
| client/locales/zh.json | Adds Chinese translation for "角色扮演评估" sidebar item |
| client/app/bundles/course/translations.ts | Adds translation message descriptor and legacy sidebar key mapper entry for scholaistic assessments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot "scholaistic" refers to https://github.com/ai-cet/scholaistic, one of our sister products. The spellings are intentional. |
|
@adi-herwana-nus I've opened a new pull request, #8197, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot I've resolved your comments. |
|
@adi-herwana-nus I've opened a new pull request, #8198, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.