-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DOMElement for retina screens #732
base: master
Are you sure you want to change the base?
Conversation
I am encountering this problem too. Can this pull request be accepted? |
Can this pull request be accepted? |
Is this available in the NextVersion ? I am also facing this issue. |
Appreciate the PR -- but the implementation of an internal private class with one method is definitely non-standard. I would recommend just adding this as a method of DOMElement for now, and it might make sense to pull it out into a separate utility function/class (like |
I'll take a look at cleaning this up |
@lannymcnie cleaned it up. |
@lannymcnie I am facing this retina issue. I see there are some conflicts. Can this be resolved? |
This fixes DOMElement for retina screens.
For example if you make your canvas retina aware like this:
Then the Easel stage is rendered with crisp text and vector shapes on your retina screen, but DOMElement is positioned and scaled incorrectly.
This PR fixes that.