Skip to content

feat: editable logic node forms + conditional branching edges - #377

Merged
vincentgrobler merged 1 commit into
mainfrom
feat/editable-logic-nodes
Apr 27, 2026
Merged

feat: editable logic node forms + conditional branching edges#377
vincentgrobler merged 1 commit into
mainfrom
feat/editable-logic-nodes

Conversation

@vincentgrobler

@vincentgrobler vincentgrobler commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Description

Three fixes for conditional and HTTP node usability:

  1. Popup visibility: NodeDetailPopup now renders for conditional and HTTP nodes (was restricted to agentNode only)

  2. Editable forms: Replace 'coming soon' placeholders with inline config forms that save on blur via onUpdateNodeData:

    • Conditional: label, field, operator (12 options), value
    • HTTP: label, method dropdown, URL, headers (add/remove), body textarea (POST/PUT/PATCH), timeout
  3. Conditional branching: true-source handle → green 'True' edge, false-source handle → red 'False' edge with labels. Edges restore with correct styling after reload.

Files changed:

  • NodeDetailPopup.tsx: full edit forms for both node types
  • WorkflowCanvas.tsx: handleUpdateNodeData, conditional edge styling, ARROW_MARKER_RED
  • useWorkflowGraph.ts: ARROW_MARKER_RED, handle-aware edge restoration

Related Issue

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📝 Documentation update
  • ♻️ Refactor (no functional changes)
  • 🧪 Test update

How Has This Been Tested?

  • Unit tests
  • Manual testing
  • Browser testing (specify browsers)

Screenshots (if applicable)

Checklist

  • My code follows the project's coding standards
  • I have run npm run lint and there are no errors
  • I have run npm run test and all tests pass
  • I have added tests for my changes (if applicable)
  • I have updated the documentation (if applicable)
  • My source files have AGPL licence headers
  • My changes generate no new TypeScript errors

Three fixes for conditional and HTTP node usability:

1. Popup visibility: NodeDetailPopup now renders for conditional
   and HTTP nodes (was restricted to agentNode only)

2. Editable forms: Replace 'coming soon' placeholders with inline
   config forms that save on blur via onUpdateNodeData:
   - Conditional: label, field, operator (12 options), value
   - HTTP: label, method dropdown, URL, headers (add/remove),
     body textarea (POST/PUT/PATCH), timeout

3. Conditional branching: true-source handle → green 'True' edge,
   false-source handle → red 'False' edge with labels. Edges
   restore with correct styling after reload.

Files changed:
- NodeDetailPopup.tsx: full edit forms for both node types
- WorkflowCanvas.tsx: handleUpdateNodeData, conditional edge
  styling, ARROW_MARKER_RED
- useWorkflowGraph.ts: ARROW_MARKER_RED, handle-aware edge
  restoration
@vercel

vercel Bot commented Apr 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
crewform Ready Ready Preview, Comment Apr 27, 2026 10:48am

@vincentgrobler
vincentgrobler merged commit 8592ed2 into main Apr 27, 2026
8 checks passed
@vincentgrobler
vincentgrobler deleted the feat/editable-logic-nodes branch April 27, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant