Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device specific config docs #14
base: main
Are you sure you want to change the base?
Add device specific config docs #14
Changes from 3 commits
f9d549f
fec8f4c
f529b2e
436f5a6
e2163c9
09f2c94
cc446d8
43910cf
f212343
ece5e3e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the range should be included in this section, but for reference if/when we move these descriptions to examples, it should read:
This config changes how to view the absolute position. It is either as a range from [-0.5, 0.5) or a range from [0, 1). As an example, if the CANcoder is at -0.25 rotations, a range of Unsigned will report an absolute position of 0.75, while a range of Signed will report an absolute position of -0.25.