Text align to use value from admin #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplified how we add the styles.
dr-bizz
added
the
On Staging
|
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
frett
reviewed
Nov 14, 2024
| @@ -60,10 +60,13 @@ const standardTypeValues = () => { | |||
| const createText = (text: string): Text => { | |||
There was a problem hiding this comment.
not something that you have to do here, just letting you know that we do expose createTest*() methods for several of the model objects, and the ones that are missing should be easy to expose/add.
They do have defined default values for all the parameters in Kotlin, but that may not be exported correctly to TypeScript.
class Text extends org.cru.godtools.shared.tool.parser.model.Content {
static createTestText(parent?: any/* org.cru.godtools.shared.tool.parser.model.Base */, text?: string, ...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding textAlign and textColor to ngStyles on the text component. Then simplified how we add the styles.
This will help with styles as the admin can control the alignment and colour from the admin tool.