[MPDX-8542] Show support goal history in donations graph

[canac]

Description

Show the historical support goal in the donations graph.

Testing

Testing is a little bit complex because the donations graph shows up in multiple places and each place loads the data independently (it isn't loaded by the graph component itself), so we need to test each place the donations graph is rendered as a HI user and a non-HI user.

• User without HI data
  • Go to the donations graph on the dashboard for a user without HI data. Check that the monthly goal is a straight line and is the value set in preferences.
  • Go to the donations graph on the donations report page for a user without HI data. Check that the monthly goal is a straight line and is the value set in preferences.
  • Go to the donations graph on the coaching page (viewing the user's own data) for a user without HI data. Check that the monthly goal is a straight line and is the value set in preferences.
  • Make the user coach Pedro and go to Pedro's coaching page (viewing Pedro's data as a coach). Check that the monthly goal line is the HI values for 2024 and is the current monthly goal preference for 2025.
• User with HI data (Pedro)
  • Go to the donations graph on the dashboard for a user without HI data. Check that the monthly goal line is the HI values for 2024 and is the current monthly goal preference for 2025.
  • Go to the donations graph on the donations report page for a user without HI data. Check that the monthly goal line is the HI values for 2024 and is the current monthly goal preference for 2025.
  • Go to the donations graph on the coaching page (viewing the user's own data) for a user without HI data. Check that the monthly goal line is the HI values for 2024 and is the current monthly goal preference for 2025.
  • Make the user coach a user without HI data and go to that user's coaching page (viewing the non-UI user as Pedro). Check that the monthly goal is a straight line and is the value set in preferences.

MPDX-8542

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://8542-hi-support-goal-history.d3dytjb8adxkk5.amplifyapp.com

[github-actions]

Bundle sizes [mpdx-react]

Compared against 480abb5

Route	Size (gzipped)	Diff
/accountLists/[accountListId]	275.84 KB	+10.85 KB
/accountLists/[accountListId]/coaching/[coachingId]	253.72 KB	+8.43 KB
/accountLists/[accountListId]/reports/coaching	253.68 KB	+8.43 KB
/accountLists/[accountListId]/reports/donations/[[...contactId]]	346.94 KB	+8.3 KB
/accountLists/[accountListId]/reports/healthIndicator	252.99 KB	added

[dr-bizz]

This is looking great! Good work. I have a few questions.

1. The coaching graph looked different than the other graph's, the goal was just a straight line rather being a dot with a line.

Coaching page:

Dashboard:

2. It appears the goal on the graph is set to $6000, but the monthly goal is set to $7000. Is this correct?

[canac]

1. The coaching graph looked different than the other graph's, the goal was just a straight line rather being a dot with a line.

I removed the dots from the line.

2. It appears the goal on the graph is set to $6000, but the monthly goal is set to $7000. Is this correct?

Yes, this is correct. It is graphing the staffEnteredGoal, which is $6000, while the machineCalculatedGoal is $7000.

@dr-bizz I also made some additional fixes and changes:

• As a coach when viewing another user's donations, clicking on the donation graph would take you to your own donations page for that month. I changed it to do nothing. You can still click on a month on your own coaching report to go to the donations page.
• For each period, if the staff entered goal is not available use the machine calculated goal instead.
• Fixed the colors of the currency bars.
• Show the goal legend in the card header when a goal is not set in preferences.

[dr-bizz]

Looks awesome. Thank you for the improvments!

[dr-bizz]

Thank you for making these improvements. I reviewed it again, and it looks great.

I have 1 question. It looks like when I removed the goal, the machine-calculated goal isn't showing on the graph. It should be the same currency, so it should show correct? This s probably me not understanding it correctly.

[canac]

It looks like when I removed the goal, the machine-calculated goal isn't showing on the graph. It should be the same currency, so it should show correct?

The blue line is the staff-entered goal for each of the months in 2024. Because it has a staff-entered goal in the health indicator data it is using that and not falling back to the machine-calculated goal. The months in 2025 have no data because there is no health indicator data for them. I should extrapolate from the last known machine-calculated goal though to fill in those missing months.