Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel api and export logs #4089

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Our observability solution doesn't currently have an API and does not allow for users to specify exporters for the OTel collector. Our patroni and pgadmin logs are missing certain desirable attributes.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

There is now an instrumentation API for configuring our OTel observability implementation. Users can use this API to configure exporters and add them to the logs pipelines. The processed patroni logs now have expected kubernetes attributes. The processed pgAdmin logs now have certain expected attributes they were missing before.

Other Information:

@dsessler7 dsessler7 requested review from benjaminjb, tony-landreth and cbandy and removed request for benjaminjb and tony-landreth February 9, 2025 01:37
internal/collector/config.go Outdated Show resolved Hide resolved
internal/collector/patroni.go Show resolved Hide resolved
internal/collector/pgadmin.go Outdated Show resolved Hide resolved
// Exporters allows users to specify which exporters they want to use in
// the logs pipeline.
// +optional
Exporters []string `json:"exporters,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 It may be possible to validate that values in this list exist as keys in config.exporters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a linear ticket to investigate

… exporters via API and add them to logs pipelines.
…pgadmin log transform. Move log message to body.
@dsessler7 dsessler7 force-pushed the otel-api-and-export-logs branch from 558c686 to ce35319 Compare February 11, 2025 19:15
@dsessler7 dsessler7 merged commit 38fc33a into CrunchyData:main Feb 11, 2025
19 checks passed
@dsessler7 dsessler7 deleted the otel-api-and-export-logs branch February 11, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants