-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otel api and export logs #4089
Merged
dsessler7
merged 3 commits into
CrunchyData:main
from
dsessler7:otel-api-and-export-logs
Feb 11, 2025
Merged
Otel api and export logs #4089
dsessler7
merged 3 commits into
CrunchyData:main
from
dsessler7:otel-api-and-export-logs
Feb 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
approved these changes
Feb 11, 2025
// Exporters allows users to specify which exporters they want to use in | ||
// the logs pipeline. | ||
// +optional | ||
Exporters []string `json:"exporters,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌱 It may be possible to validate that values in this list exist as keys in config.exporters
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a linear ticket to investigate
pkg/apis/postgres-operator.crunchydata.com/v1beta1/postgrescluster_types.go
Show resolved
Hide resolved
… exporters via API and add them to logs pipelines.
…pgadmin log transform. Move log message to body.
558c686
to
ce35319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Our observability solution doesn't currently have an API and does not allow for users to specify exporters for the OTel collector. Our patroni and pgadmin logs are missing certain desirable attributes.
What is the new behavior (if this is a feature change)?
There is now an instrumentation API for configuring our OTel observability implementation. Users can use this API to configure exporters and add them to the logs pipelines. The processed patroni logs now have expected kubernetes attributes. The processed pgAdmin logs now have certain expected attributes they were missing before.
Other Information: