Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug provider APIs are not all wrapped through the approval #874

Open
4 of 5 tasks
0xisk opened this issue Sep 14, 2023 · 0 comments · Fixed by #875 · May be fixed by #1110
Open
4 of 5 tasks

Bug provider APIs are not all wrapped through the approval #874

0xisk opened this issue Sep 14, 2023 · 0 comments · Fixed by #875 · May be fixed by #1110
Assignees
Labels
🪲 bug Something isn't working
Milestone

Comments

@0xisk
Copy link
Member

0xisk commented Sep 14, 2023

How to reproduce?

  1. I changed the demo to have a button for directly calling one of the exposed RPC like GET_CONNECTED_IDENTITY_DATA through calling client.getConnectedIdentity()
  2. I did step (1) without going trough client.connect() which has the approval step.
  3. I did get output showing the connected identity metadata.

How to resolve?

I think all the exposed APIs should be handling the Approval part internally inside the background script. Which means that all the RPC calls inside the Provider are protected from inside the extension.

  • Screenshot of the button Get Connected Identity
    Image

  • Screenshot of the output data after clicking on Get Connected Identity
    Image

Tasks

  1. 🛠 enhancement
    0xisk
  2. 🛠 enhancement
    0xisk
  3. 🛠 enhancement
    0xisk
  4. 🛠 enhancement
    0xisk
@0xisk 0xisk converted this from a draft issue Sep 14, 2023
@0xisk 0xisk self-assigned this Sep 14, 2023
@0xisk 0xisk added the 🪲 bug Something isn't working label Sep 14, 2023
@0xisk 0xisk added this to the v0.3.0 milestone Sep 14, 2023
@0xisk 0xisk linked a pull request Sep 18, 2023 that will close this issue
6 tasks
@0xmad 0xmad modified the milestones: v0.3.0, v0.4.0 Sep 18, 2023
@0xmad 0xmad moved this from 📋 Backlog to ✍️ To do in Crypt-Keeper Extension Sep 19, 2023
@0xisk 0xisk closed this as completed in #875 Oct 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Crypt-Keeper Extension Oct 4, 2023
@0xisk 0xisk reopened this Oct 6, 2023
@github-project-automation github-project-automation bot moved this from ✅ Done to ✍️ To do in Crypt-Keeper Extension Oct 6, 2023
@0xisk 0xisk changed the title bug: provider APIs are not all wrapped through the approval Bug provider APIs are not all wrapped through the approval Oct 9, 2023
@0xmad 0xmad modified the milestones: v0.5.0, v0.6.0 Oct 12, 2023
@0xmad 0xmad moved this from ✍️ To do to 👀 Review / QA in Crypt-Keeper Extension Nov 3, 2023
@0xmad 0xmad linked a pull request Nov 3, 2023 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
Status: 👀 Review / QA
2 participants