Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: credential checks #1110

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: credential checks #1110

wants to merge 4 commits into from

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Nov 3, 2023

Explanation

This PR adds support for approval, connections checks and refactoring for VCs and VPs.

Details are below:

  • Refactoring for verifiable credentials and presentations
  • Use approval and connection checks for adding vc and generating vp
  • Jest missing refactoring for deprecated methods
  • Minor ui improvements for credentials
  • Add tests for providers package

Related Issues

Blocked by #1109
Closes #876
Closes #874
Closes #900
Closes #264
Closes #344

Screenshots

Expand

image

Manual Testing Steps

Check VC and VP related functions.

Pre-Merge Checklist

Assignees Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

Reviewers Checklist

  • Manual testing checked and passed.

@0xmad 0xmad added the 🛠 enhancement Optimizing current features label Nov 3, 2023
@0xmad 0xmad added this to the v0.6.0 milestone Nov 3, 2023
@0xmad 0xmad self-assigned this Nov 3, 2023
@0xmad 0xmad changed the title feat: credential cheks feat: credential checks Nov 3, 2023
@0xmad 0xmad force-pushed the feature/credentials branch 7 times, most recently from fda2c23 to c0f9f66 Compare November 13, 2023 09:41
@0xmad 0xmad force-pushed the feature/credentials branch 4 times, most recently from 2c75b9a to db5ba10 Compare November 17, 2023 16:11
@0xmad 0xmad enabled auto-merge (squash) November 22, 2023 16:05
@0xmad 0xmad force-pushed the feature/credentials branch 2 times, most recently from 1bf9a7e to e62a870 Compare November 24, 2023 15:57
- [x] Refactoring for verifiable credentials and presentations
- [x] Use approval and connection checks for adding vc and generating vp
- [x] Jest missing refactoring for deprecated methods
- [x] Minor ui improvements for credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 enhancement Optimizing current features
Projects
Status: 👀 Review / QA
1 participant