Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: derive import identities from seed phrase #1046

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Oct 18, 2023

Explanation

This PR adds support for importing identities and derive them from user's seed phrase.

Details are below:

  • Add signature options for identity import
  • Minor refactoring

Related Issues

Blocked by #1040
Related to #906

Screenshots

Expand

image

Manual Testing Steps

  1. Try to import identity from demo, connect, create identity screens.
  2. Check cryptkeeper sign
  3. Check metamask sign with and without connect

Pre-Merge Checklist

Assignees Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

Reviewers Checklist

  • Manual testing checked and passed.

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Oct 18, 2023
@0xmad 0xmad added this to the v0.6.0 milestone Oct 18, 2023
@0xmad 0xmad self-assigned this Oct 18, 2023
@0xmad 0xmad changed the title feat: devire import identities from seed phrase feat: derive import identities from seed phrase Oct 18, 2023
@0xmad 0xmad force-pushed the feature/derive-import branch 8 times, most recently from 79aa2ab to ac5c70f Compare October 24, 2023 17:01
@0xmad 0xmad marked this pull request as ready for review October 24, 2023 17:04
@0xmad 0xmad mentioned this pull request Oct 24, 2023
10 tasks
- [x] Add signature options for identity import
- [x] Minor refactoring
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @0xmad!

@0xmad 0xmad merged commit b12f7f3 into main Oct 26, 2023
10 checks passed
@0xmad 0xmad deleted the feature/derive-import branch October 26, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 new feature Troubleshooting new feature issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants