test: injected providers #369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmad
reviewed
May 16, 2023
0xmad
requested changes
May 17, 2023
| @@ -3,7 +3,7 @@ import { Emitter, createNanoEvents } from "nanoevents"; | |||
| import { Events, EventHandler, EventName } from "./types"; | |||
|
|
|||
| export default class EventEmitter { | |||
| private emitter: Emitter<Events>; | |||
| emitter: Emitter<Events>; | |||
|
|
||
| beforeEach(() => { | ||
| // Mocking private dependencies | ||
| const mockTryInject = jest.spyOn(CryptKeeperInjectedProvider.prototype as any, "tryInject"); |
There was a problem hiding this comment.
Private dependencies is not the same as private methods.
Here you need to spy on window.postMessage and check that it has been called with specific params
| /** | ||
| * @jest-environment jsdom | ||
| */ | ||
| /* eslint @typescript-eslint/no-explicit-any: 0 */ // --> OFF |
0xisk
force-pushed
the
test/injected-providers
branch
from
5b12089
to
c6b8a22
Compare
|
These changes are related to old project structure so they are not applicable for monorepo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Unit-testing for:
More Information
Screenshots/Screencaps
N/A
Manual Testing Steps
N/A
Pre-Merge Checklist