Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update input styles #975

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat: update input styles #975

merged 3 commits into from
Oct 10, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Oct 6, 2023 •
edited
Loading

Explanation

This PR changes input styles for the application.

Details are below:

  • Update input styles for the application
  • Add manual import for identity

Related Issues

Related to #906

Screenshots

Expand

image
image

Manual Testing Steps

N/A

Pre-Merge Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Oct 6, 2023
@0xmad 0xmad added this to the v0.5.0 milestone Oct 6, 2023
@0xmad 0xmad self-assigned this Oct 6, 2023
0xisk
0xisk requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xmad! From the manual testing I noticed that the text inputs for RLN and Semaphore approval screen could be changeable where they should not be.

Screenshot_20231009_142352
Screenshot_20231009_142331

@0xmad 0xmad requested a review from 0xisk October 9, 2023 14:07
@0xmad 0xmad enabled auto-merge (squash) October 9, 2023 14:07
@0xmad 0xmad force-pushed the feature/manual-identity-paste branch 2 times, most recently from 2d99900 to fd15380 Compare October 9, 2023 17:03
@0xmad
feat: update input styles
e7294e0 
- [x] Update input styles for the application
- [x] Add manual import for identity
@0xmad
fix: add missing exports
2c56fc1
@0xmad
fix: pass readonly to text field
b8174af
@0xmad 0xmad force-pushed the feature/manual-identity-paste branch from fd15380 to b8174af Compare October 9, 2023 21:38
@0xmad 0xmad mentioned this pull request Oct 9, 2023
Merged
9 tasks
@0xmad 0xmad merged commit 591a345 into main Oct 10, 2023
10 checks passed
@0xmad 0xmad deleted the feature/manual-identity-paste branch October 10, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xisk 0xisk 0xisk approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xmad 0xmad

Labels
🌱 new feature Troubleshooting new feature issues
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@0xmad @0xisk